Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo): drop any #9474

Merged
merged 1 commit into from
Oct 17, 2024
Merged

chore(demo): drop any #9474

merged 1 commit into from
Oct 17, 2024

Conversation

splincode
Copy link
Member

If you really need to skip type checking, you can use something that Typescript 3.0 introduced: the unknown type. Unlike any, unknown is safer to use in the sense that before actually doing something with data of this type, we must do some sort of checking, whereas any has no restrictions.

https://dev.to/arikaturika/typescript-why-to-use-unknown-instead-of-any-41i8

Copy link

lumberjack-bot bot commented Oct 13, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Oct 13, 2024

Visit the preview URL for this PR (updated for commit b08c7c8):

https://taiga-previews--pr9474-splincode-demo-unkno-yai5xkum.web.app

(expires Fri, 18 Oct 2024 12:51:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Oct 13, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
295.05KB +10%
demo/browser/vendor.(hash).js
255.06KB +10%
demo/browser/runtime.(hash).js
43.17KB +10%
demo/browser/styles.(hash).css
16.27KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

No change in files bundle size

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.16MB (+13B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode force-pushed the splincode/demo-unknown branch from e3d6897 to b08c7c8 Compare October 17, 2024 12:47
@splincode splincode requested a review from a team as a code owner October 17, 2024 12:47
@splincode splincode enabled auto-merge (squash) October 17, 2024 12:47
@splincode splincode merged commit c17cd11 into main Oct 17, 2024
25 checks passed
@splincode splincode deleted the splincode/demo-unknown branch October 17, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants