feat(addon-table): disable column sorting on demand

[tsironis13]

Fixes #8244

The idea is to enable sorting only for columns where the [requiredSort]="true" is provided

[lumberjack-bot]

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.13%. Comparing base (4a26b1a) to head (79e0ea9).
Report is 355 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9382      +/-   ##
==========================================
- Coverage   75.68%   75.13%   -0.56%     
==========================================
  Files        1216     1234      +18     
  Lines       19068    19407     +339     
  Branches     2091     2018      -73     
==========================================
+ Hits        14432    14581     +149     
- Misses       4592     4783     +191     
+ Partials       44       43       -1     

Flag	Coverage Δ
summary	75.13% <ø> (-0.56%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bundlemon]

BundleMon

Unchanged files (5)

Status	Path	Size	Limits
✅	demo/browser/main.(hash).js	294.52KB	+10%
✅	demo/browser/vendor.(hash).js	247.33KB	+10%
✅	demo/browser/runtime.(hash).js	42.98KB	+10%
✅	demo/browser/styles.(hash).css	16.27KB	+10%
✅	demo/browser/polyfills.(hash).js	11.18KB	+10%

Total files change -1B 0%

Unchanged groups (1)

Status	Path	Size	Limits
✅	demo/browser/*..js	7.11MB	-

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[waterplea]

This is not what the fix needs to be. The issue was about making tuiSortable dynamic. But looking at it again I don't think we need it at all. All it does it connect sorter with key, I think it is already working as expected. This current PR is definitely not right, requiredSort means when you click the column it switches from asc/desc and never to unsorted, unlike other columns with sorter which disable sorting on 3rd click.

[tsironis13]

This is not what the fix needs to be. The issue was about making tuiSortable dynamic. But looking at it again I don't think we need it at all. All it does it connect sorter with key, I think it is already working as expected. This current PR is definitely not right, requiredSort means when you click the column it switches from asc/desc and never to unsorted, unlike other columns with sorter which disable sorting on 3rd click.

Ok @waterplea , can we disable sorting dynamically for some columns with the current codebase?

my point is, if we have a way to provide this UI functionality to the end user and I am asking because I am new to the project and maybe I am missing something. Otherwise, it would be nice to create a new PR and provide this option also.

[waterplea]

@tsironis13 sorry, I was sure I posted the explanation in the issue but it looks like I only typed it and forgot to press "Send" :) I ended up doing this PR myself because as I looked into the actual issue it turned out to be not as simple as I thought. It's going to be fixed in today's release.