Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-table): hydration error while configuring table #9374

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix(addon-table): hydration error while configuring table #9374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions projects/addon-table/components/table/th-group/th-group.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,16 @@ import {TuiTableTh} from '../th/th.component';
templateUrl: './th-group.template.html',
changeDetection: ChangeDetectionStrategy.OnPush,
providers: [TUI_TABLE_PROVIDER],
host: {
/**
* TODO: fix later
* Be careful and thoughtful about using this attribute.
* It is intended as a last resort workaround.
* Components that break hydration should be
* considered bugs that need to be fixed.
*/
ngSkipHydration: 'true',
splincode marked this conversation as resolved.
Show resolved Hide resolved
},
})
export class TuiTableThGroup<T extends Partial<Record<keyof T, any>>>
implements AfterContentInit
Expand Down
10 changes: 10 additions & 0 deletions projects/addon-table/components/table/tr/tr.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,16 @@ import {TuiTableTd} from '../td/td.component';
templateUrl: './tr.template.html',
changeDetection: ChangeDetectionStrategy.OnPush,
providers: [TUI_TABLE_PROVIDER],
host: {
/**
* TODO: fix later
* Be careful and thoughtful about using this attribute.
* It is intended as a last resort workaround.
* Components that break hydration should be
* considered bugs that need to be fixed.
*/
ngSkipHydration: 'true',
},
})
export class TuiTableTr<T extends Partial<Record<keyof T, any>>>
implements AfterContentInit
Expand Down
7 changes: 7 additions & 0 deletions projects/core/components/expand/expand.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,13 @@ export const TUI_EXPAND_LOADED = 'tui-expand-loaded';
changeDetection: ChangeDetectionStrategy.OnPush,
animations: [tuiParentAnimation],
host: {
/**
* TODO: fix later
* Be careful and thoughtful about using this attribute.
* It is intended as a last resort workaround.
* Components that break hydration should be
* considered bugs that need to be fixed.
*/
ngSkipHydration: 'true',
'[style.height.px]': 'height',
'[class._loading]': 'loading',
Expand Down
Loading