Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo-cypress): improve Cypress snapshots quality #9352

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

nsbarsukov
Copy link
Member

Previous behavior

New behavior

@nsbarsukov nsbarsukov self-assigned this Oct 4, 2024
Copy link

lumberjack-bot bot commented Oct 4, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

bundlemon bot commented Oct 4, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
292.96KB +10%
demo/browser/vendor.(hash).js
247.36KB +10%
demo/browser/runtime.(hash).js
42.88KB +10%
demo/browser/styles.(hash).css
16.27KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.1MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Visit the preview URL for this PR (updated for commit cbe4d41):

https://taiga-previews--pr9352-improve-cypress-ct-s-33qhxmle.web.app

(expires Sat, 05 Oct 2024 13:21:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@nsbarsukov nsbarsukov force-pushed the improve-cypress-ct-screenshot-quality branch from 0d333fd to ce1d647 Compare October 4, 2024 13:09
@nsbarsukov nsbarsukov force-pushed the improve-cypress-ct-screenshot-quality branch from ce1d647 to cbe4d41 Compare October 4, 2024 13:20
@nsbarsukov nsbarsukov marked this pull request as ready for review October 4, 2024 13:33
@splincode splincode merged commit 1eca0ca into main Oct 5, 2024
25 of 26 checks passed
@splincode splincode deleted the improve-cypress-ct-screenshot-quality branch October 5, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants