Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix overriding default dropdown options #9348

Merged
merged 5 commits into from
Oct 7, 2024
Merged

fix(core): fix overriding default dropdown options #9348

merged 5 commits into from
Oct 7, 2024

Conversation

vladimirpotekhin
Copy link
Member

@vladimirpotekhin vladimirpotekhin commented Oct 4, 2024 •
edited
Loading

Fixes #4935

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 4, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 7ee936b):

https://taiga-previews--pr9348-options-fix-4p8t1b36.web.app

(expires Sat, 05 Oct 2024 14:37:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 4, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 293.01KB (+48B +0.02%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 247.36KB +10%
✅ demo/browser/runtime.(hash).js
 42.88KB +10%
✅ demo/browser/styles.(hash).css
 16.27KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change +55B +0.01%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.1MB (+183B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@splincode splincode merged commit db84c4c into main Oct 7, 2024
25 of 26 checks passed
@splincode splincode deleted the options-fix branch October 7, 2024 10:05
This was referenced Oct 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov

@mdlufy mdlufy Awaiting requested review from mdlufy

Assignees

@vladimirpotekhin vladimirpotekhin

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - TuiComboBox incorrectly gets width parameter
4 participants
@vladimirpotekhin @waterplea @splincode @taiga-family-bot