Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): revert ngSkipHydration #9320

Merged
merged 1 commit into from
Oct 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion projects/legacy/components/arrow/arrow.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import {TUI_ARROW_OPTIONS} from './arrow.options';
styleUrls: ['./arrow.style.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
ngSkipHydration: 'true',
'[class._rotated]': 'rotated',
'[class._small]': 'small',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ const HEX_MODE_LENGTH = 6;
templateUrl: './color-edit.template.html',
styleUrls: ['./color-edit.style.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
ngSkipHydration: 'true',
},
})
export class TuiColorEditComponent {
@Input()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ import type {TuiPoint} from '@taiga-ui/core/types';
templateUrl: './color-picker.template.html',
styleUrls: ['./color-picker.style.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
ngSkipHydration: 'true',
},
})
export class TuiColorPickerComponent {
private readonly sanitizer = inject(DomSanitizer);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ import {
templateUrl: './color-selector.template.html',
styleUrls: ['./color-selector.style.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
ngSkipHydration: 'true',
},
})
export class TuiColorSelectorComponent {
private readonly selectorOptions = inject(TUI_COLOR_SELECTOR_OPTIONS);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ import {TuiPickerService} from '../services/picker.service';
styleUrls: ['./flat-picker.style.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
providers: [TuiPickerService],
host: {
ngSkipHydration: 'true',
},
})
export class TuiFlatPickerComponent {
protected readonly $ = inject(TuiPickerService)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import {TuiPickerService} from '../services/picker.service';
changeDetection: ChangeDetectionStrategy.OnPush,
providers: [TuiPickerService],
host: {
ngSkipHydration: 'true',
'(document:mouseup)': 'onMouseUp()',
},
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ import {TuiPickerService} from '../services/picker.service';
styleUrls: ['./linear-picker.style.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
providers: [TuiPickerService],
host: {
ngSkipHydration: 'true',
},
})
export class TuiLinearPickerComponent {
protected readonly $ = inject(TuiPickerService)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ import {
templateUrl: './palette.template.html',
styleUrls: ['./palette.style.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
ngSkipHydration: 'true',
},
})
export class TuiPaletteComponent {
@Input()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ import type {PolymorpheusContent} from '@taiga-ui/polymorpheus';
],
viewProviders: [FIXED_DROPDOWN_CONTROLLER_PROVIDER],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'size',
},
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ type MaskMode = 'gradient' | 'hex' | 'rgb';
changeDetection: ChangeDetectionStrategy.OnPush,
viewProviders: [tuiDropdownOptionsProvider({maxHeight: 600})],
host: {
ngSkipHydration: 'true',
'(click)': 'onClick()',
},
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ import {TUI_INPUT_COPY_OPTIONS} from './input-copy.options';
tuiAsControl(TuiInputCopyComponent),
],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'size',
},
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ import {map} from 'rxjs';
TUI_MOBILE_CALENDAR_PROVIDER,
],
host: {
ngSkipHydration: 'true',
'[class._editable]': 'editable',
'[attr.data-size]': 'size',
'(click)': 'onClick()',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ import {map} from 'rxjs';
TUI_MOBILE_CALENDAR_PROVIDER,
],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'size',
'(click)': 'onClick()',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ const DATE_TIME_SEPARATOR = ', ';
tuiDateStreamWithTransformer(TUI_DATE_TIME_VALUE_TRANSFORMER),
],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'size',
'(click)': 'onClick()',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ import {map} from 'rxjs';
TUI_MOBILE_CALENDAR_PROVIDER,
],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'size',
'(click)': 'onClick()',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ import {
TuiMonthPipe,
],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'size',
},
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ import {
TuiMonthPipe,
],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'size',
},
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ export const TUI_NUMBER_VALUE_TRANSFORMER =
TEXTFIELD_CONTROLLER_PROVIDER,
],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'size',
'(keydown.arrowDown)': 'onArrow(-step)',
'(keydown.arrowUp)': 'onArrow(step)',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import {TUI_INPUT_PASSWORD_OPTIONS} from './input-password.options';
tuiAsControl(TuiInputPasswordComponent),
],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'size',
},
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ const MASK_SYMBOLS = /[ \-_()]/g;
],
viewProviders: [FIXED_DROPDOWN_CONTROLLER_PROVIDER],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'size',
'(paste.capture.prevent.stop)': 'onPaste($event)',
'(drop.capture.prevent.stop)': 'onPaste($event)',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ function isText(value: string): boolean {
],
viewProviders: [FIXED_DROPDOWN_CONTROLLER_PROVIDER],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'size',
},
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ import type {PolymorpheusContent} from '@taiga-ui/polymorpheus';
TEXTFIELD_CONTROLLER_PROVIDER,
],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'controller.size',
'[class._label-outside]': 'controller.labelOutside',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ import type {PolymorpheusContent} from '@taiga-ui/polymorpheus';
TEXTFIELD_CONTROLLER_PROVIDER,
],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'controller.size',
'[class._label-outside]': 'controller.labelOutside',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ const TAG_VERTICAL_SPACE_REM = 0.125;
],
viewProviders: [FIXED_DROPDOWN_CONTROLLER_PROVIDER],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'size',
'[class._icon-start]': 'iconStart',
'[class._expandable]': 'expandable',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ import {TUI_INPUT_TIME_OPTIONS} from './input-time.options';
],
viewProviders: [FIXED_DROPDOWN_CONTROLLER_PROVIDER],
host: {
ngSkipHydration: 'true',
'(click)': 'onClick()',
'[attr.data-size]': 'size',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import type {TuiInputTimeDirective} from '../input-time.directive';
styleUrls: ['./native-time.style.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
ngSkipHydration: 'true',
type: 'time',
'[attr.list]': 'autoId',
'[tabIndex]': '-1',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ const UP_TO_4_DIGITS_REG = /^\d{0,4}$/;
tuiAsControl(TuiInputYearComponent),
],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'size',
},
})
Expand Down
1 change: 0 additions & 1 deletion projects/legacy/components/input/input.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ import type {PolymorpheusContent} from '@taiga-ui/polymorpheus';
],
viewProviders: [FIXED_DROPDOWN_CONTROLLER_PROVIDER],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'size',
},
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ import {TuiSelectOptionComponent} from '@taiga-ui/legacy/components/select-optio
templateUrl: './multi-select-option.template.html',
styleUrls: ['./multi-select-option.style.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
ngSkipHydration: 'true',
},
})
export class TuiMultiSelectOptionComponent<
T extends any[],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import {combineLatest, map} from 'rxjs';
styleUrls: ['./multi-select-group.style.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
ngSkipHydration: 'true',
'[class._label]': 'label',
},
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ import {AbstractTuiNativeMultiSelect} from './native-multi-select/native-multi-s
],
viewProviders: [FIXED_DROPDOWN_CONTROLLER_PROVIDER],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'size',
'[class._editable]': 'editable',
'[class._expandable]': 'rows > 1',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import {AbstractTuiNativeMultiSelect} from './native-multi-select';
},
],
host: {
ngSkipHydration: 'true',
'[attr.aria-invalid]': 'host.invalid',
'[disabled]': 'host.disabled || control.readOnly',
'[tabIndex]': 'host.focusable ? 0 : -1',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {AbstractTuiNativeMultiSelect} from './native-multi-select';
},
],
host: {
ngSkipHydration: 'true',
'[attr.aria-invalid]': 'host.invalid',
'[disabled]': 'host.disabled || control.readOnly',
'[tabIndex]': 'host.focusable ? 0 : -1',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ export const TUI_ICON_START_PADDINGS: Record<TuiSizeL | TuiSizeS, number> = {
TEXTFIELD_CONTROLLER_PROVIDER,
],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'size',
'[class._readonly]': 'readOnly',
'[class._hidden]': 'inputHidden',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {TUI_TEXTFIELD_HOST} from '@taiga-ui/legacy/tokens';
changeDetection: ChangeDetectionStrategy.OnPush,
providers: [TEXTFIELD_CONTROLLER_PROVIDER],
host: {
ngSkipHydration: 'true',
type: 'text',
'[attr.id]': 'id',
'[attr.inputMode]': 'inputMode',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import type {TuiPrimitiveTextfield} from '../primitive-textfield-types';
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
changeDetection: ChangeDetectionStrategy.Default,
host: {
ngSkipHydration: 'true',
'[class._table]': 'isContextTable',
'[class._filler]': 'filler',
'(animationstart)': 'ngDoCheck()',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ import {distinctUntilChanged, EMPTY, map, merge, startWith, Subject} from 'rxjs'
templateUrl: './select-option.template.html',
styleUrls: ['./select-option.style.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
ngSkipHydration: 'true',
},
})
export class TuiSelectOptionComponent<T> implements OnInit, DoCheck {
private readonly host = inject<TuiDataListHost<T>>(TUI_DATA_LIST_HOST);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import type {TuiSelectDirective} from '../select.directive';
},
],
host: {
ngSkipHydration: 'true',
'[attr.aria-invalid]': 'host.invalid',
'[disabled]': 'host.disabled || control.readOnly',
'[tabIndex]': 'host.focusable ? 0 : -1',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import type {TuiSelectDirective} from '../select.directive';
},
],
host: {
ngSkipHydration: 'true',
'[attr.aria-invalid]': 'host.invalid',
'[disabled]': 'host.disabled || control.readOnly',
'[tabIndex]': 'host.focusable ? 0 : -1',
Expand Down
1 change: 0 additions & 1 deletion projects/legacy/components/select/select.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ import {TUI_SELECT_OPTIONS} from './select.options';
],
viewProviders: [FIXED_DROPDOWN_CONTROLLER_PROVIDER],
host: {
ngSkipHydration: 'true',
'[attr.data-size]': 'size',
},
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ import {TUI_SHEET, TUI_SHEET_SCROLL} from '../../sheet-tokens';
templateUrl: './sheet-bar.template.html',
styleUrls: ['./sheet-bar.style.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
ngSkipHydration: 'true',
},
})
export class TuiSheetBarComponent {
private readonly sheet = inject(TUI_SHEET);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ export const TUI_SHEET_ID = 'tui-sheet-id';
templateUrl: './sheet-heading.template.html',
styleUrls: ['./sheet-heading.style.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
ngSkipHydration: 'true',
},
})
export class TuiSheetHeadingComponent implements AfterViewInit {
private readonly el = tuiInjectElement();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ import {TUI_SHEET_PROVIDERS} from './sheet.providers';
providers: TUI_SHEET_PROVIDERS,
animations: [tuiSlideInTop],
host: {
ngSkipHydration: 'true',
role: 'dialog',
'[attr.aria-labelledby]': 'id',
'[class._ios]': 'isIos',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ import {TuiSheetService} from '../../sheet.service';
styleUrls: ['./sheets-host.style.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
animations: [tuiSlideInTop, tuiFadeIn],
host: {
ngSkipHydration: 'true',
},
})
export class TuiSheetsHostComponent implements OnInit {
private readonly service = inject(TuiSheetService);
Expand Down
3 changes: 0 additions & 3 deletions projects/legacy/components/svg/svg.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ export interface TuiIconError {
templateUrl: './svg.template.html',
styleUrls: ['./svg.style.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
ngSkipHydration: 'true',
},
})
export class TuiSvgComponent {
private icon: TuiSafeHtml = '';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import type {TuiTableBarOptions} from './table-bar.options';
changeDetection: ChangeDetectionStrategy.OnPush,
animations: [tuiSlideInTop, tuiParentAnimation],
host: {
ngSkipHydration: 'true',
'[@tuiSlideInTop]': 'animation',
'[attr.data-appearance]': 'context.mode',
},
Expand Down
Loading
Loading