Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo): add ::before on data-type attribute #9269

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

galanggg
Copy link
Contributor

@galanggg galanggg commented Sep 30, 2024

Fixes #9222

Before
Screenshot 2024-09-30 at 18 30 52

After
Screenshot 2024-09-30 at 18 30 58

Copy link

lumberjack-bot bot commented Sep 30, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode splincode changed the title fix(demo): add ::before on data-type attribute chore(demo): add ::before on data-type attribute Sep 30, 2024
Copy link

bundlemon bot commented Sep 30, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
288.49KB +10%
demo/browser/vendor.(hash).js
247.14KB +10%
demo/browser/runtime.(hash).js
42.8KB +10%
demo/browser/styles.(hash).css
16.17KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change -3B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.18MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.31%. Comparing base (4a26b1a) to head (d56d4da).
Report is 272 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9269      +/-   ##
==========================================
- Coverage   75.68%   75.31%   -0.38%     
==========================================
  Files        1216     1233      +17     
  Lines       19068    19329     +261     
  Branches     2091     2021      -70     
==========================================
+ Hits        14432    14558     +126     
- Misses       4592     4731     +139     
+ Partials       44       40       -4     
Flag Coverage Δ
summary 75.31% <ø> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waterplea waterplea merged commit 68eb3e0 into taiga-family:main Sep 30, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - different behavior border radius for [data-type=holiday]
3 participants