-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kit): added search function in international phone component #8546
feat(kit): added search function in international phone component #8546
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8546 +/- ##
==========================================
- Coverage 75.68% 75.23% -0.45%
==========================================
Files 1216 1233 +17
Lines 19068 19360 +292
Branches 2091 2084 -7
==========================================
+ Hits 14432 14566 +134
- Misses 4592 4749 +157
- Partials 44 45 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BundleMonFiles updated (2)
Unchanged files (3)
Total files change +848B +0.14% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
projects/kit/components/input-phone-international/input-phone-international.template.html
Outdated
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.template.html
Outdated
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.template.html
Outdated
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.template.html
Outdated
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.template.html
Outdated
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.template.html
Outdated
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.component.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.template.html
Outdated
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.style.less
Show resolved
Hide resolved
194a26b
to
2eab7ad
Compare
Thank you for this PR! I've added some comments, please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked carefully again and added some more comments, after those I believe it's good to go 👍
projects/kit/components/input-phone-international/input-phone-international.component.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.component.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.component.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.component.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.component.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.component.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.style.less
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.component.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.style.less
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.style.less
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.component.ts
Show resolved
Hide resolved
projects/kit/components/input-phone-international/input-phone-international.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now, @denzo1993 could you rebase and resolve conflicts please so we can merge this PR? Thank you for this extensive contribution!
ec08698
to
603d8a1
Compare
603d8a1
to
3be602c
Compare
Added search input in dropdown menu of international phone component
2024-08-15.00.56.41.mov