Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): added search function in international phone component #8546

Merged

Conversation

denzo1993
Copy link
Contributor

@denzo1993 denzo1993 commented Aug 14, 2024

Added search input in dropdown menu of international phone component

2024-08-15.00.56.41.mov

Copy link

lumberjack-bot bot commented Aug 14, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.23%. Comparing base (4a26b1a) to head (3be602c).
Report is 336 commits behind head on main.

Files with missing lines Patch % Lines
...ternational/input-phone-international.component.ts 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8546      +/-   ##
==========================================
- Coverage   75.68%   75.23%   -0.45%     
==========================================
  Files        1216     1233      +17     
  Lines       19068    19360     +292     
  Branches     2091     2084       -7     
==========================================
+ Hits        14432    14566     +134     
- Misses       4592     4749     +157     
- Partials       44       45       +1     
Flag Coverage Δ
summary 75.23% <95.83%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Aug 14, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
293.69KB (+742B +0.25%) +10%
demo/browser/runtime.(hash).js
42.98KB (+106B +0.24%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
247.36KB +10%
demo/browser/styles.(hash).css
16.27KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +848B +0.14%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.11MB (+7KB +0.1%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode force-pushed the feat-input-phone-international-search branch from 194a26b to 2eab7ad Compare August 15, 2024 13:50
@waterplea
Copy link
Collaborator

Thank you for this PR! I've added some comments, please take a look.

@denzo1993 denzo1993 requested a review from waterplea August 15, 2024 23:53
Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked carefully again and added some more comments, after those I believe it's good to go 👍

@denzo1993 denzo1993 requested a review from waterplea August 19, 2024 22:29
@denzo1993 denzo1993 requested a review from waterplea August 27, 2024 15:25
Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now, @denzo1993 could you rebase and resolve conflicts please so we can merge this PR? Thank you for this extensive contribution!

@splincode splincode force-pushed the feat-input-phone-international-search branch 3 times, most recently from ec08698 to 603d8a1 Compare October 4, 2024 12:37
@splincode splincode self-requested a review October 4, 2024 12:37
@splincode splincode force-pushed the feat-input-phone-international-search branch from 603d8a1 to 3be602c Compare October 4, 2024 12:48
@splincode splincode merged commit 24572b1 into taiga-family:main Oct 4, 2024
24 checks passed
This was referenced Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants