Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): CalendarRange not update selectedActivePeriod, when value updates #8529

Closed
wants to merge 1 commit into from

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Aug 14, 2024

Closes #8527

After update value:

As Is:

as-is.mov

To Be:

to-be.mov

Copy link

lumberjack-bot bot commented Aug 14, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Aug 14, 2024

Visit the preview URL for this PR (updated for commit 873dd26):

https://taiga-ui--pr8529-mdlufy-calendar-rang-2lfm05ns.web.app

(expires Thu, 15 Aug 2024 17:06:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Aug 14, 2024

BundleMon

Files updated (3)
Status Path Size Limits
demo/browser/main.(hash).js
397.45KB (+4.82KB +1.23%) +10%
demo/browser/runtime.(hash).js
41.92KB (+590B +1.39%) +10%
demo/browser/vendor.(hash).js
214.55KB (-25B -0.01%) +10%
Unchanged files (2)
Status Path Size Limits
demo/browser/polyfills.(hash).js
15.22KB +10%
demo/browser/styles.(hash).css
1.39KB +10%

Total files change +5.37KB +0.81%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.45MB (+35.52KB +1.44%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@mdlufy mdlufy changed the title fix(kit): CalendarRange not update selectedActivePeriod, when value updates [WIP] fix(kit): CalendarRange not update selectedActivePeriod, when value updates Aug 14, 2024
@mdlufy mdlufy force-pushed the mdlufy/calendar-range-fix branch from cfe3356 to c28e27c Compare August 14, 2024 13:06
@mdlufy mdlufy added the v3 label Aug 14, 2024
@mdlufy mdlufy force-pushed the mdlufy/calendar-range-fix branch 2 times, most recently from 8aba4f6 to 62620a5 Compare August 14, 2024 16:39
@mdlufy mdlufy force-pushed the mdlufy/calendar-range-fix branch from 62620a5 to 873dd26 Compare August 14, 2024 17:03
@mdlufy mdlufy requested a review from splincode August 14, 2024 17:06
@mdlufy mdlufy changed the title [WIP] fix(kit): CalendarRange not update selectedActivePeriod, when value updates fix(kit): CalendarRange not update selectedActivePeriod, when value updates Aug 14, 2024
@mdlufy mdlufy marked this pull request as ready for review August 14, 2024 17:07
@waterplea
Copy link
Collaborator

Closing in favor of #8595

@waterplea waterplea closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants