Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(demo): DocDemo generates invalid urls during attempts to patch query params #8480

Merged
merged 2 commits into from
Aug 12, 2024
Merged

chore(demo): DocDemo generates invalid urls during attempts to patch query params #8480

merged 2 commits into from
Aug 12, 2024

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Aug 12, 2024 •
edited
Loading

Closes #8466

@nsbarsukov nsbarsukov added the v3 label Aug 12, 2024
@nsbarsukov nsbarsukov self-assigned this Aug 12, 2024
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 12, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 12, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit f6cff75):

https://taiga-ui--pr8480-documentation-base-h-zvin9l46.web.app

(expires Tue, 13 Aug 2024 14:37:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon BundleMon
Copy link

bundlemon bot commented Aug 12, 2024 •
edited
Loading

BundleMon

Files updated (3)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 396.73KB (+4.1KB +1.04%) +10%
✅ demo/browser/runtime.(hash).js
 41.72KB (+384B +0.91%) +10%
✅ demo/browser/vendor.(hash).js
 214.55KB (-25B -0.01%) +10%
Unchanged files (2)
Status Path Size Limits
✅ demo/browser/polyfills.(hash).js
 15.22KB +10%
✅ demo/browser/styles.(hash).css
 1.39KB +10%

Total files change +4.45KB +0.67%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 2.44MB (+25.88KB +1.05%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@nsbarsukov nsbarsukov changed the title [WIP] chore(demo): DocDemo generates invalid urls during attempts to patch query params chore(demo): DocDemo generates invalid urls during attempts to patch query params Aug 12, 2024
@nsbarsukov nsbarsukov marked this pull request as ready for review August 12, 2024 14:35
@splincode splincode merged commit 33c621f into v3.x Aug 12, 2024
32 checks passed
@splincode splincode deleted the documentation-base-href-problems branch August 12, 2024 14:57
@nsbarsukov nsbarsukov linked an issue Aug 12, 2024 that may be closed by this pull request
🐞 - Documentation invalid url on v3 #8466
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@splincode splincode splincode approved these changes

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner

Assignees

@nsbarsukov nsbarsukov

Labels
ready to merge v3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - Documentation invalid url on v3
3 participants
@nsbarsukov @splincode @vladimirpotekhin