Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): icon hover on readonly #8469

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix(kit): icon hover on readonly #8469

merged 1 commit into from
Aug 13, 2024

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Aug 12, 2024

Closes #8389

Icon on hover:

As Is:
image

To Be:
image

Copy link

lumberjack-bot bot commented Aug 12, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Aug 12, 2024

Visit the preview URL for this PR (updated for commit 8bfa8e6):

https://taiga-ui--pr8469-mdlufy-icons-hover-9by1m89v.web.app

(expires Tue, 13 Aug 2024 10:57:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Aug 12, 2024

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+396.78KB +10%
demo/browser/vendor.(hash).js
+214.55KB +10%
demo/browser/runtime.(hash).js
+41.72KB +10%
demo/browser/polyfills.(hash).js
+15.22KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +669.66KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.44MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

@mdlufy mdlufy marked this pull request as ready for review August 12, 2024 10:37
@mdlufy mdlufy marked this pull request as draft August 12, 2024 10:40
@mdlufy mdlufy force-pushed the mdlufy/icons-hover branch from b82162e to b34c3f1 Compare August 12, 2024 10:48
@mdlufy mdlufy marked this pull request as ready for review August 12, 2024 10:49
@mdlufy mdlufy force-pushed the mdlufy/icons-hover branch from b34c3f1 to 8bfa8e6 Compare August 12, 2024 10:54
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v3.x@ef7e6f1). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             v3.x    #8469   +/-   ##
=======================================
  Coverage        ?   71.56%           
=======================================
  Files           ?     1468           
  Lines           ?    16272           
  Branches        ?     2351           
=======================================
  Hits            ?    11645           
  Misses          ?     4244           
  Partials        ?      383           
Flag Coverage Δ
addon-charts 71.35% <ø> (?)
addon-doc 60.62% <ø> (?)
addon-mobile 56.89% <ø> (?)
addon-table 60.49% <ø> (?)
addon-tablebars 96.15% <ø> (?)
cdk 78.37% <ø> (?)
core 77.54% <ø> (?)
kit 70.38% <ø> (?)
summary 71.56% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode merged commit f191f9a into v3.x Aug 13, 2024
32 of 33 checks passed
@splincode splincode deleted the mdlufy/icons-hover branch August 13, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants