Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk): redundant assert log if hours are greater than 23 #8449

Merged
merged 1 commit into from
Aug 12, 2024
Merged

fix(cdk): redundant assert log if hours are greater than 23 #8449

merged 1 commit into from
Aug 12, 2024

Conversation

Chiorufarewerin
Copy link
Contributor

Closes #8372

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 9, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon BundleMon
Copy link

bundlemon bot commented Aug 9, 2024

BundleMon

Files added (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 +396.73KB +10%
✅ demo/browser/vendor.(hash).js
 +214.55KB +10%
✅ demo/browser/runtime.(hash).js
 +41.72KB +10%
✅ demo/browser/polyfills.(hash).js
 +15.22KB +10%
✅ demo/browser/styles.(hash).css
 +1.39KB +10%

Total files change +669.62KB

Groups added (1)
Status Path Size Limits
✅ demo/browser/*..js
 +2.44MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

@splincode splincode added the v3 label Aug 9, 2024
@splincode splincode merged commit ef7e6f1 into taiga-family:v3.x Aug 12, 2024
32 of 33 checks passed
@taiga-family-bot taiga-family-bot mentioned this pull request Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner

Assignees
No one assigned
Labels
v3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chiorufarewerin @waterplea @splincode