Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): CalendarRange defaultViewedMonth shows correct calendars months #8400

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Aug 7, 2024

Closes #8331

When set input [defaultViewedMonth]:

As Is:

image

To Be:

image

Copy link

lumberjack-bot bot commented Aug 7, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Visit the preview URL for this PR (updated for commit 6ae4be3):

https://taiga-ui--pr8400-mdlufy-calendar-mont-wzqusb3z.web.app

(expires Wed, 14 Aug 2024 09:34:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Aug 7, 2024

BundleMon

Files updated (3)
Status Path Size Limits
demo/browser/main.(hash).js
396.79KB (+4.16KB +1.06%) +10%
demo/browser/runtime.(hash).js
41.72KB (+384B +0.91%) +10%
demo/browser/vendor.(hash).js
214.55KB (-25B -0.01%) +10%
Unchanged files (2)
Status Path Size Limits
demo/browser/polyfills.(hash).js
15.22KB +10%
demo/browser/styles.(hash).css
1.39KB +10%

Total files change +4.51KB +0.68%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.44MB (+25.94KB +1.05%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@mdlufy mdlufy force-pushed the mdlufy/calendar-month branch from faa9a07 to d821dd7 Compare August 7, 2024 14:34
@mdlufy mdlufy changed the title fix(kit): fix CalendarRange defaultViewedMonth shows correct left and right calendars fix(kit): fix CalendarRange defaultViewedMonth shows correct calendars months Aug 7, 2024
@mdlufy mdlufy added the v3 label Aug 8, 2024
Comment on lines 36 to 37
await expect(page).toHaveScreenshot(
'calendar-range-default-viewed-month.png',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this test fail ? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

@mdlufy mdlufy Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's another issue - #8494
Playwright test removed

@mdlufy mdlufy force-pushed the mdlufy/calendar-month branch from d821dd7 to 6ae4be3 Compare August 13, 2024 09:29
@mdlufy mdlufy changed the title fix(kit): fix CalendarRange defaultViewedMonth shows correct calendars months fix(kit): CalendarRange defaultViewedMonth shows correct calendars months Aug 13, 2024
@mdlufy mdlufy merged commit bcfd27f into v3.x Aug 13, 2024
32 of 33 checks passed
@mdlufy mdlufy deleted the mdlufy/calendar-month branch August 13, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants