Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use less strict dep constraints for deprecated @taiga-ui/{addon-preview,addon-tablebars} #8357

Merged

Conversation

nsbarsukov
Copy link
Member

Use project WITHOUT --legacy-peer-deps config.

nx migrate @taiga-ui/cdk@next
npm i

it throws

~/WebstormProjects/twfm-ui-2 git:[test-taiga-migrations]
npm i
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: [email protected]
npm error Found: @taiga-ui/[email protected]
npm error node_modules/@taiga-ui/cdk
npm error   @taiga-ui/cdk@"4.0.0-rc.8" from the root project
npm error
npm error Could not resolve dependency:
npm error peer @taiga-ui/cdk@"^3.83.0" from @taiga-ui/[email protected]
npm error node_modules/@taiga-ui/addon-tablebars
npm error   @taiga-ui/addon-tablebars@"3.83.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /Users/n.barsukov/.npm/_logs/2024-08-05T14_45_53_945Z-eresolve-report.txt

npm error A complete log of this run can be found in: /Users/n.barsukov/.npm/_logs/2024-08-05T14_45_53_945Z-debug-0.log

Copy link

lumberjack-bot bot commented Aug 5, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Visit the preview URL for this PR (updated for commit 5beede1):

https://taiga-ui--pr8357-less-strict-dep-cons-xiio6s32.web.app

(expires Tue, 06 Aug 2024 15:34:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Aug 5, 2024

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+394.82KB +10%
demo/browser/vendor.(hash).js
+214.55KB +10%
demo/browser/runtime.(hash).js
+41.5KB +10%
demo/browser/polyfills.(hash).js
+15.22KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +667.48KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.43MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

@vladimirpotekhin vladimirpotekhin merged commit f3f05f9 into v3.x Aug 6, 2024
32 of 34 checks passed
@vladimirpotekhin vladimirpotekhin deleted the less-strict-dep-constraint-for-deprecated-packages branch August 6, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants