Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(core): Dialog should hide close icon if closeable equals to Observable<false> (#8206)" #8349

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

nsbarsukov
Copy link
Member

Copy link

lumberjack-bot bot commented Aug 5, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Visit the preview URL for this PR (updated for commit dac5bc9):

https://taiga-ui--pr8349-revert-dialog-closea-9q7ay87r.web.app

(expires Tue, 06 Aug 2024 14:08:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@nsbarsukov nsbarsukov added the v3 label Aug 5, 2024
Copy link

bundlemon bot commented Aug 5, 2024

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+395.03KB +10%
demo/browser/vendor.(hash).js
+214.55KB +10%
demo/browser/runtime.(hash).js
+41.5KB +10%
demo/browser/polyfills.(hash).js
+15.22KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +667.7KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.43MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

@nsbarsukov nsbarsukov merged commit 45c6107 into v3.x Aug 6, 2024
34 of 35 checks passed
@nsbarsukov nsbarsukov deleted the revert-dialog-closeable-false-v3 branch August 6, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants