fix(kit): Dialog with closeable should work with hot observables too
#8341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsbarsukov
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin,
splincode and
mdlufy
as code owners
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
|
Visit the preview URL for this PR (updated for commit 5fc226b): https://taiga-ui--pr8341-dialog-closeable-i9fwwmlg.web.app (expires Tue, 06 Aug 2024 12:20:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
BundleMonFiles added (5)
Total files change +665.27KB Groups added (1)
Final result: ✅ View report in BundleMon website ➡️ |
splincode
approved these changes
Aug 5, 2024
waterplea
approved these changes
Aug 5, 2024
nsbarsukov
changed the title
Dialog with closeable should work with hot observables tooDialog with closeable should work with hot observables too
nsbarsukov
commented
Aug 5, 2024
nsbarsukov
force-pushed
the
dialog-closeable
branch
from
0264962 to
5fc226b
Compare
nsbarsukov
changed the title
Dialog with closeable should work with hot observables tooDialog with closeable should work with hot observables too
vladimirpotekhin
approved these changes
Aug 5, 2024
splincode
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stackblitz.com/edit/angular-uir9k2?file=src%2Fapp%2Fapp.component.ts