Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-mobile): possibility drop mobile calendar header #8265

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

MillerSvt
Copy link
Collaborator

Closes #

Copy link

lumberjack-bot bot commented Jul 30, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Jul 30, 2024

Visit the preview URL for this PR (updated for commit 86f8c7a):

https://taiga-ui--pr8265-mobile-calendar-fix-xlo8abl5.web.app

(expires Tue, 06 Aug 2024 14:04:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Jul 30, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/runtime.(hash).js
41.24KB (+55B +0.13%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/main.(hash).js
278.01KB +10%
demo/browser/vendor.(hash).js
216.27KB +10%
demo/browser/styles.(hash).css
11.55KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

Total files change +62B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
6.67MB (+8.25KB +0.12%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@MillerSvt MillerSvt force-pushed the mobile-calendar-fix-for-v4 branch from e259184 to 7911144 Compare July 30, 2024 11:44
@splincode splincode added the v4 4.0 candidate label Jul 30, 2024
@splincode splincode force-pushed the mobile-calendar-fix-for-v4 branch from 7911144 to 0f4928e Compare July 31, 2024 08:44
@MillerSvt MillerSvt force-pushed the mobile-calendar-fix-for-v4 branch from 0f4928e to 38c8d27 Compare July 31, 2024 09:19
@MillerSvt MillerSvt marked this pull request as draft August 1, 2024 12:00
@splincode
Copy link
Member

@MillerSvt any updates?

@MillerSvt
Copy link
Collaborator Author

@splincode awaiting #8296

@splincode
Copy link
Member

@MillerSvt merged

@MillerSvt MillerSvt force-pushed the mobile-calendar-fix-for-v4 branch 2 times, most recently from 4a05e42 to 1f02c7c Compare August 5, 2024 13:46
@MillerSvt MillerSvt marked this pull request as ready for review August 5, 2024 13:56
@splincode splincode force-pushed the mobile-calendar-fix-for-v4 branch from 1f02c7c to 86f8c7a Compare August 5, 2024 14:01
@splincode splincode requested a review from nsbarsukov August 5, 2024 14:01
@splincode
Copy link
Member

@MillerSvt why cypress tests are failed?

@MillerSvt
Copy link
Collaborator Author

@splincode I think test is incorrect.

  1. In Test component, we provide TUI_CALENDAR_DATE_STREAM with TuiDay of tomorrow
  2. When we create component, tomorrow date will automatically select
  3. When we click on today date, TuiDayRange should be TuiDayRange(today, tomorrow) (not TuiDayRange(today, today))

What do you think?

@splincode
Copy link
Member

@MillerSvt can you rewrite the test?

@MillerSvt MillerSvt force-pushed the mobile-calendar-fix-for-v4 branch from a40b858 to 6a0d916 Compare August 8, 2024 08:44
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Visit the preview URL for this PR (updated for commit 6a0d916):

https://taiga-previews--pr8265-mobile-calendar-fix-8mvql0d8.web.app

(expires Fri, 09 Aug 2024 08:48:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@splincode
Copy link
Member

@nsbarsukov

@waterplea waterplea merged commit 819b17b into main Aug 19, 2024
27 of 28 checks passed
@waterplea waterplea deleted the mobile-calendar-fix-for-v4 branch August 19, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 4.0 candidate
Development

Successfully merging this pull request may close these issues.

4 participants