Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk): add dialog name for override overlay styles #8239

Closed
wants to merge 1 commit into from
Closed

feat(cdk): add dialog name for override overlay styles #8239

wants to merge 1 commit into from

Conversation

splincode
Copy link
Member

image

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 28, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode splincode added the v4 4.0 candidate label Jul 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit a7110be):

https://taiga-ui--pr8239-splincode-feat-dialo-qdqjafdi.web.app

(expires Mon, 29 Jul 2024 07:54:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon BundleMon
Copy link

bundlemon bot commented Jul 28, 2024

BundleMon

Files updated (3)
Status Path Size Limits
✅ demo/browser/runtime.(hash).js
 40.93KB (+43B +0.1%) +10%
✅ demo/browser/main.(hash).js
 275.27KB (+25B +0.01%) +10%
✅ demo/browser/styles.(hash).css
 11.15KB (-131B -1.13%) +10%
Unchanged files (2)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 230.95KB +10%
✅ demo/browser/polyfills.(hash).js
 11.21KB +10%

Total files change -63B -0.01%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 6.63MB (+6.95KB +0.1%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@waterplea
Copy link
Collaborator

I would like to not increase complexity until we really need something like that. Did somebody request it internally?

@splincode splincode closed this Jul 31, 2024
@splincode splincode deleted the splincode/feat/dialog-name branch July 31, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea Awaiting requested review from waterplea

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov

@mdlufy mdlufy Awaiting requested review from mdlufy

Assignees

@splincode splincode

Labels
v4 4.0 candidate
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@splincode @waterplea