Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): dialog-button-handling #8085

Closed
wants to merge 1 commit into from
Closed

feat(core): dialog-button-handling #8085

wants to merge 1 commit into from

Conversation

PawelTr
Copy link
Contributor

@PawelTr PawelTr commented Jul 11, 2024

Closes #

Copy link

lumberjack-bot bot commented Jul 11, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@PawelTr PawelTr closed this by deleting the head repository Jul 11, 2024
Copy link

bundlemon bot commented Jul 11, 2024

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+384.65KB +10%
demo/browser/vendor.(hash).js
+213.01KB +10%
demo/browser/runtime.(hash).js
+40.64KB +10%
demo/browser/polyfills.(hash).js
+11.25KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +650.95KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.36MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

@@ -22,7 +22,7 @@
tuiAutoFocus
tuiButton
type="button"
(click)="context.$implicit.complete()"
(click)="context.$implicit.next(undefined)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to be completeWith(undefined) and a typecast has to be here, because this is a little hack. This button can appear only in string dialogs so they cannot receive value any other way, no need to change type to O | undefined, it's a special case that is too hard to properly handle with types and there no need to really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants