Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-table): support nullable values in tuiTableSort #7890

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

splincode
Copy link
Member

No description provided.

Copy link

lumberjack-bot bot commented Jun 21, 2024

Failed tests ❌

After <= Diff => Before

dropdown-selection/dropdown-selection.cy.ts/__diff_output__/1-2-dropdown-selection.diff.png
dropdown-selection/dropdown-selection.cy.ts/__diff_output__/1-3-dropdown-selection.diff.png
input/input-table.cy.ts/components/__diff_output__/input_table__3_3.diff.png
input/input-table.cy.ts/components/__diff_output__/input_table__4_1.diff.png

(updated for commit 175d321)

@splincode splincode force-pushed the splincode/feat-addon-table branch from 0637329 to 175d321 Compare June 21, 2024 09:27
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 175d321):

https://taiga-ui--pr7890-splincode-feat-addon-7qrzkwnm.web.app

(expires Sat, 22 Jun 2024 09:30:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Jun 21, 2024

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+392.36KB +10%
demo/browser/vendor.(hash).js
+214.57KB +10%
demo/browser/runtime.(hash).js
+41.32KB +10%
demo/browser/polyfills.(hash).js
+11.25KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +660.89KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.4MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

@splincode splincode merged commit 439871e into v3.x Jun 25, 2024
32 of 33 checks passed
@splincode splincode deleted the splincode/feat-addon-table branch June 25, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants