Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-doc): Navigation fix invalid two-way binding error in Angular v18 #7838

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

hakimio
Copy link
Contributor

@hakimio hakimio commented Jun 19, 2024

Closes #7824

Copy link

lumberjack-bot bot commented Jun 19, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.98%. Comparing base (43c0ebb) to head (236f0c1).
Report is 804 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7838      +/-   ##
==========================================
- Coverage   70.19%   65.98%   -4.21%     
==========================================
  Files        1460     1132     -328     
  Lines       15934    13919    -2015     
  Branches     2292     2008     -284     
==========================================
- Hits        11185     9185    -2000     
- Misses       4369     4556     +187     
+ Partials      380      178     -202     
Flag Coverage Δ
summary 65.98% <ø> (-4.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode added the v4 4.0 candidate label Jun 19, 2024
Copy link

bundlemon bot commented Jun 19, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
293.97KB (+138B +0.05%) +10%
demo/browser/runtime.(hash).js
40.58KB (+12B +0.03%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
243.82KB +10%
demo/browser/styles.(hash).css
13.95KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

Total files change +150B +0.02%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.06MB (+1.41KB +0.02%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode merged commit d56ef21 into taiga-family:main Jun 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 4.0 candidate
Development

Successfully merging this pull request may close these issues.

🐞 - addon-doc fails to compile in Angular v18 app
3 participants