-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kit): CalendarRange
should not distinguish ranges with same dates and different names
#7804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdlufy
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin,
nsbarsukov and
splincode
as code owners
June 17, 2024 19:37
Failed tests ❌After <= Diff => Before (updated for commit 5dc65a2) |
Visit the preview URL for this PR (updated for commit 5dc65a2): https://taiga-ui--pr7804-mdlufy-fix-calendar-esvtn8ul.web.app (expires Fri, 21 Jun 2024 14:47:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
BundleMonFiles added (5)
Total files change +660.9KB Groups added (1)
Final result: ✅ View report in BundleMon website ➡️ |
mdlufy
force-pushed
the
mdlufy/fix-calendar-range
branch
2 times, most recently
from
June 18, 2024 10:40
858fe1e
to
e7dfb76
Compare
mdlufy
changed the title
fix(kit): save current active period to distinguish periods with same…
fix(kit): save current active period to distinguish periods with same date ranges
Jun 18, 2024
mdlufy
force-pushed
the
mdlufy/fix-calendar-range
branch
from
June 18, 2024 10:45
e7dfb76
to
4d87003
Compare
mdlufy
force-pushed
the
mdlufy/fix-calendar-range
branch
from
June 18, 2024 14:31
4d87003
to
5b3ec81
Compare
mdlufy
changed the title
fix(kit): save current active period to distinguish periods with same date ranges
fix(kit): Jun 18, 2024
CalendarRange
should not distinguish ranges with same dates and different names
splincode
approved these changes
Jun 18, 2024
mdlufy
force-pushed
the
mdlufy/fix-calendar-range
branch
2 times, most recently
from
June 20, 2024 13:20
cacdcd0
to
0dc6d1b
Compare
…es and different names
mdlufy
force-pushed
the
mdlufy/fix-calendar-range
branch
from
June 20, 2024 14:40
0dc6d1b
to
5dc65a2
Compare
vladimirpotekhin
approved these changes
Jun 20, 2024
splincode
approved these changes
Jun 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7781
Problem: on item select, control value hold only range, not considering name/content
And when it attemps to get current active period, in finds only by range
Solutions: