-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kit): InputDateTime
should format textfield value on blur
#7659
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonFiles added (5)
Total files change +660.73KB Groups added (1)
Final result: ✅ View report in BundleMon website ➡️ |
InputDateTime
should format textfield value on blur
@@ -312,7 +312,7 @@ export class TuiInputDateTimeComponent | |||
if ( | |||
this.value[0] === null || | |||
this.value[1] !== null || | |||
this.nativeValue.length <= this.fillerLength + DATE_TIME_SEPARATOR.length || | |||
this.nativeValue.length === this.fillerLength || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alyonagerasimova
Thanks for your contribution!
-
Could you add playwright tests for this case inside this file, please ?
test('Good description', async ({page}) => { await tuiGoto(page, '/components/input-date-time/API?timeMode=HH:MM:SS.MSS'); await inputDateTime.textfield.fill('07.06.2024, 23:59'); await inputDateTime.textfield.blur(); await expect(inputDateTime.textfield).toHaveValue('07.06.2024, 23:59:00.000'); });
-
Cherry-pick your fix to
main
branch too, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you closed your previous PR to main
:
Sorry for confusion.
Let's me clarify it.
We require this fix in both v3.x
and main
branches (2 PRs in total).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I prematurely deleted my first fork repository in order to fork it again. I will open a new PR in the main branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #7638