Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-table): added a check that total is zero #7111

Merged

Conversation

AlexeyPortnyagin
Copy link
Contributor

@AlexeyPortnyagin AlexeyPortnyagin commented Mar 28, 2024

Closes #7025

Copy link

lumberjack-bot bot commented Mar 28, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@AlexeyPortnyagin AlexeyPortnyagin changed the title fix(addon-table): added a check that total is zero fix(addon-table): v3.x added a check that total is zero Mar 28, 2024
Copy link

bundlemon bot commented Mar 28, 2024

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+388.63KB +10%
demo/browser/vendor.(hash).js
+214.22KB +10%
demo/browser/runtime.(hash).js
+41.11KB +10%
demo/browser/polyfills.(hash).js
+11.25KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +656.6KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.39MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v3.x@9facc78). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             v3.x    #7111   +/-   ##
=======================================
  Coverage        ?   60.50%           
=======================================
  Files           ?       45           
  Lines           ?      476           
  Branches        ?       29           
=======================================
  Hits            ?      288           
  Misses          ?      183           
  Partials        ?        5           
Flag Coverage Δ
addon-mobile ∅ <ø> (?)
addon-table 60.50% <ø> (?)
summary 60.50% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode changed the title fix(addon-table): v3.x added a check that total is zero fix(addon-table): added a check that total is zero Mar 28, 2024
@vladimirpotekhin vladimirpotekhin merged commit 6da0b4b into taiga-family:v3.x Mar 28, 2024
32 of 33 checks passed
This was referenced Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants