Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): remove pure getNativeElements #7102

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

AlexeyPortnyagin
Copy link
Contributor

Closes #7017

Copy link

lumberjack-bot bot commented Mar 27, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 67.13%. Comparing base (43c0ebb) to head (4c5478f).
Report is 321 commits behind head on main.

❗ Current head 4c5478f differs from pull request most recent head cbbb20f. Consider uploading reports for the commit cbbb20f to get more accurate results

Files Patch % Lines
...ojects/kit/components/stepper/stepper.component.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7102      +/-   ##
==========================================
- Coverage   70.19%   67.13%   -3.07%     
==========================================
  Files        1460     1409      -51     
  Lines       15934    15087     -847     
  Branches     2292     2095     -197     
==========================================
- Hits        11185    10128    -1057     
- Misses       4369     4767     +398     
+ Partials      380      192     -188     
Flag Coverage Δ
summary 67.13% <0.00%> (-3.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Mar 27, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
312.42KB +10%
demo/browser/vendor.(hash).js
204.17KB +10%
demo/browser/runtime.(hash).js
38.51KB +10%
demo/browser/styles.(hash).css
13.85KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

Total files change -8B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.44MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@waterplea
Copy link
Collaborator

Same thing will be needed for v3.x branch

@AlexeyPortnyagin
Copy link
Contributor Author

AlexeyPortnyagin commented Mar 28, 2024

Same thing will be needed for v3.x branch

Can you tell me how to pull up the 3.x branch in my fork?

git pull https://github.com/taiga-family/taiga-ui.git v3.x - I get a lot of conflicts

UPD: I figured it out.

git remote add taiga https://github.com/taiga-family/taiga-ui.git
git fetch taiga 
git checkout --no-track taiga/v3.x

@vladimirpotekhin vladimirpotekhin added community contribution This issue was closed by a PR from the community v4 4.0 candidate labels Mar 28, 2024
@vladimirpotekhin vladimirpotekhin enabled auto-merge (squash) March 28, 2024 06:32
@vladimirpotekhin vladimirpotekhin merged commit 5fd94f7 into taiga-family:main Mar 28, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution This issue was closed by a PR from the community v4 4.0 candidate
Development

Successfully merging this pull request may close these issues.

🐞 - Stepper: autoscroll to selected element not working after updating stepper state
4 participants