Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kit): TasbWithMore fix redundant left margin for single element #7022

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix(kit): TasbWithMore fix redundant left margin for single element #7022

merged 1 commit into from
Mar 19, 2024

Conversation

vladimirpotekhin
Copy link
Member

Closes #6989

@vladimirpotekhin vladimirpotekhin added the v4 4.0 candidate label Mar 18, 2024
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Mar 18, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 0749272):

https://taiga-ui--pr7022-tabs-more-ixwllkcr.web.app

(expires Tue, 19 Mar 2024 17:45:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon BundleMon
Copy link

bundlemon bot commented Mar 18, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 319.35KB (-566B -0.17%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 210.51KB +10%
✅ demo/browser/runtime.(hash).js
 36.71KB +10%
✅ demo/browser/styles.(hash).css
 13.78KB +10%
✅ demo/browser/polyfills.(hash).js
 11.21KB +10%

Total files change -576B -0.09%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 2.21MB (+2.25KB +0.1%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

waterplea
waterplea approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also take care of [tuiTabs] selector?

projects/kit/components/tabs/tab/tab.style.less Show resolved Hide resolved
@vladimirpotekhin vladimirpotekhin merged commit 9245d8b into main Mar 19, 2024
25 of 26 checks passed
@vladimirpotekhin vladimirpotekhin deleted the tabs-more branch March 19, 2024 08:05
vladimirpotekhin added a commit that referenced this pull request Mar 19, 2024
@vladimirpotekhin
fix(kit): TasbWithMore fix redundant left margin for single element (…
87a78eb 
…#7022)

(cherry picked from commit 9245d8b)
splincode pushed a commit that referenced this pull request Mar 19, 2024
@vladimirpotekhin
fix(kit): TasbWithMore fix redundant left margin for single element (…
d5818aa 
…#7022) (#7026)
This was referenced Mar 19, 2024
Merged
Merged
This was referenced Apr 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov

Assignees

@vladimirpotekhin vladimirpotekhin

Labels
ready to merge v4 4.0 candidate
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - Unwanted margin for tui-tabs-with-more component
3 participants
@vladimirpotekhin @waterplea @splincode