refactor: support angular 16 #6966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splincode
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin and
nsbarsukov
as code owners
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
splincode
force-pushed
the
splincode/ng
branch
3 times, most recently
from
e33d93b to
15959af
Compare
|
Visit the preview URL for this PR (updated for commit a16f5c0): https://taiga-ui--pr6966-splincode-ng-d63y22ln.web.app (expires Tue, 12 Mar 2024 12:48:52 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
BundleMonFiles updated (3)
Unchanged files (2)
Total files change +3.33KB +0.57% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
splincode
force-pushed
the
splincode/ng
branch
9 times, most recently
from
7332a47 to
d92381a
Compare
splincode
commented
Mar 11, 2024
| @@ -59,6 +59,6 @@ export class TuiScrollbarComponent { | |||
| const scrollTop = offsetTop + offsetHeight / 2 - clientHeight / 2; | |||
| const scrollLeft = offsetLeft + offsetWidth / 2 - clientWidth / 2; | |||
|
|
|||
| nativeElement.scrollTo(scrollLeft, scrollTop); | |||
| nativeElement.scrollTo?.(scrollLeft, scrollTop); | |||
There was a problem hiding this comment.
I don't know why Jest fail in combo-box.component.spec.ts without that
splincode
force-pushed
the
splincode/ng
branch
2 times, most recently
from
73d3812 to
67ae369
Compare
nsbarsukov
requested changes
Mar 11, 2024
vladimirpotekhin
approved these changes
Mar 11, 2024
nsbarsukov
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.