Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Icon component move to core, make standalone #6965

Merged
merged 5 commits into from
Mar 12, 2024
Merged

refactor!: Icon component move to core, make standalone #6965

merged 5 commits into from
Mar 12, 2024

Conversation

vladimirpotekhin
Copy link
Member

Closes #

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Mar 7, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@vladimirpotekhin vladimirpotekhin added the v4 4.0 candidate label Mar 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 440ad94):

https://taiga-ui--pr6965-icon-move-ofkv5pzc.web.app

(expires Wed, 13 Mar 2024 12:17:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon BundleMon
Copy link

bundlemon bot commented Mar 7, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 318.61KB (+231B +0.07%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 210.51KB +10%
✅ demo/browser/runtime.(hash).js
 36.5KB +10%
✅ demo/browser/styles.(hash).css
 13.78KB +10%
✅ demo/browser/polyfills.(hash).js
 11.21KB +10%

Total files change +225B +0.04%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 2.21MB (+53B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@vladimirpotekhin vladimirpotekhin force-pushed the icon-move branch 2 times, most recently from e2020d6 to 29a1c5d Compare March 11, 2024 09:55
@nsbarsukov nsbarsukov merged commit 9b14669 into main Mar 12, 2024
26 checks passed
@nsbarsukov nsbarsukov deleted the icon-move branch March 12, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsbarsukov nsbarsukov nsbarsukov approved these changes

@splincode splincode splincode approved these changes

@waterplea waterplea Awaiting requested review from waterplea

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi

Assignees

@vladimirpotekhin vladimirpotekhin

Labels
ready to merge v4 4.0 candidate
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vladimirpotekhin @splincode @nsbarsukov @taiga-family-bot @KrollikRoddzer