refactor: fix possible memory leak #6963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splincode
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin and
nsbarsukov
as code owners
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonFiles updated (1)
Unchanged files (4)
Total files change +56B +0.01% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
|
Visit the preview URL for this PR (updated for commit 780b50e): https://taiga-ui--pr6963-splincode-fix-1hgqrl65.web.app (expires Fri, 08 Mar 2024 07:53:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
nsbarsukov
reviewed
Mar 7, 2024
Comment on lines
+73
to
+74
| inject(TuiFocusVisibleService) | ||
| .pipe(takeUntil(inject(TuiDestroyService, {self: true}))) |
There was a problem hiding this comment.
Comment on lines
+41
to
+42
| this.end$ | ||
| .pipe(takeUntil(this.destroy$)) |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.