Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experimental): Avatar fix error when using SafeResourceUrl #6842

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

splincode
Copy link
Member

No description provided.

Copy link

lumberjack-bot bot commented Feb 21, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

Visit the preview URL for this PR (updated for commit b8483a0):

https://taiga-ui--pr6842-splincode-fix-avatar-fbccq13z.web.app

(expires Thu, 22 Feb 2024 08:25:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Feb 21, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
386.07KB (+1.41KB +0.37%) +10%
demo/browser/runtime.(hash).js
40.73KB (+89B +0.21%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
213.01KB +10%
demo/browser/polyfills.(hash).js
11.25KB +10%
demo/browser/styles.(hash).css
1.39KB +10%

Total files change +1.5KB +0.23%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.37MB (+10.94KB +0.45%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v3.x@04255ba). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             v3.x    #6842   +/-   ##
=======================================
  Coverage        ?   71.95%           
=======================================
  Files           ?     1457           
  Lines           ?    16033           
  Branches        ?     2299           
=======================================
  Hits            ?    11537           
  Misses          ?     4122           
  Partials        ?      374           
Flag Coverage Δ
addon-charts 71.52% <ø> (?)
addon-doc 60.58% <ø> (?)
addon-mobile 60.50% <ø> (?)
addon-table 60.75% <ø> (?)
addon-tablebars 96.15% <ø> (?)
cdk 78.48% <ø> (?)
core 77.63% <ø> (?)
kit 70.26% <ø> (?)
summary 71.95% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode changed the title fix(experimental): support SafeResourceUrl in resolver fix(experimental): convert SafeResourceUrl to string Feb 21, 2024
@splincode splincode changed the title fix(experimental): convert SafeResourceUrl to string fix(experimental): convert SafeResourceUrl to string in tui-avatar Feb 21, 2024
@waterplea
Copy link
Collaborator

The proper message I'd say is:
fix(experimental): Avatar fix error when using SafeResourceUrl

@splincode splincode changed the title fix(experimental): convert SafeResourceUrl to string in tui-avatar fix(experimental): Avatar fix error when using SafeResourceUrl Feb 21, 2024
@splincode splincode merged commit a79ba00 into v3.x Feb 21, 2024
33 of 34 checks passed
@splincode splincode deleted the splincode/fix/avatar branch February 21, 2024 09:34
This was referenced Feb 26, 2024
This was referenced Mar 19, 2024
This was referenced Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants