Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): add auto lineHeight for TuiLineClamp #6806

Closed
wants to merge 1 commit into from

Conversation

MillerSvt
Copy link
Collaborator

No description provided.

@MillerSvt MillerSvt force-pushed the line-clamp-auto-height branch from e1cc351 to 6b5b01b Compare February 16, 2024 03:15
Copy link

lumberjack-bot bot commented Feb 16, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 6b5b01b):

https://taiga-ui--pr6806-line-clamp-auto-heig-xrz74lwo.web.app

(expires Sat, 17 Feb 2024 03:18:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (v3.x@069a650). Click here to learn what that means.

Files Patch % Lines
.../kit/components/line-clamp/line-clamp.component.ts 14.28% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             v3.x    #6806   +/-   ##
=======================================
  Coverage        ?   70.49%           
=======================================
  Files           ?     1097           
  Lines           ?    13116           
  Branches        ?     1859           
=======================================
  Hits            ?     9246           
  Misses          ?     3557           
  Partials        ?      313           
Flag Coverage Δ
addon-charts 71.46% <ø> (?)
addon-doc 60.58% <ø> (?)
addon-mobile 60.63% <ø> (?)
addon-table 60.75% <ø> (?)
addon-tablebars 96.15% <ø> (?)
cdk ∅ <ø> (?)
core 77.63% <ø> (?)
kit 70.23% <14.28%> (?)
summary 70.49% <14.28%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

if (this.lineHeight === 'auto') {
return (
parseInt(
this.window.getComputedStyle(this.el.nativeElement).lineHeight,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did this initially and it turned out to be very slow when there are multiple instances of it. I think we better not add this option. One day we will be able to use lh CSS units :harold_hides_the_pain:

@MillerSvt MillerSvt closed this Feb 16, 2024
@MillerSvt MillerSvt deleted the line-clamp-auto-height branch February 16, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants