Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): Push fix directive change detection #6681

Merged
merged 2 commits into from
Feb 5, 2024
Merged

fix(kit): Push fix directive change detection #6681

merged 2 commits into from
Feb 5, 2024

Conversation

waterplea
Copy link
Collaborator

Closes #

Copy link

lumberjack-bot bot commented Feb 5, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

bundlemon bot commented Feb 5, 2024

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+384.02KB +10%
demo/browser/vendor.(hash).js
+212.98KB +10%
demo/browser/runtime.(hash).js
+40.55KB +10%
demo/browser/polyfills.(hash).js
+11.25KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +650.19KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.35MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Visit the preview URL for this PR (updated for commit a71bc07):

https://taiga-ui--pr6681-push-zdtnjrgs.web.app

(expires Tue, 06 Feb 2024 08:55:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v3.x@0c1cd7d). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             v3.x    #6681   +/-   ##
=======================================
  Coverage        ?   70.28%           
=======================================
  Files           ?      443           
  Lines           ?     5896           
  Branches        ?      920           
=======================================
  Hits            ?     4144           
  Misses          ?     1596           
  Partials        ?      156           
Flag Coverage Δ
core ∅ <0.00%> (?)
kit 70.28% <0.00%> (?)
summary 70.28% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode merged commit bdd144d into v3.x Feb 5, 2024
31 of 32 checks passed
@splincode splincode deleted the push branch February 5, 2024 10:10
@splincode splincode added the v3 label Feb 5, 2024
This was referenced Feb 20, 2024
This was referenced Mar 19, 2024
This was referenced Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants