Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core)!: drop *.scss files because difficult to maintain between less and sass #6608

Closed
wants to merge 1 commit into from

Conversation

splincode
Copy link
Member

No description provided.

Copy link

lumberjack-bot bot commented Jan 30, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 45e5fea):

https://taiga-ui--pr6608-splincode-feat-drop-9fhfv8ej.web.app

(expires Wed, 31 Jan 2024 12:11:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Jan 30, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
345.98KB +10%
demo/browser/vendor.(hash).js
214.63KB +10%
demo/browser/runtime.(hash).js
34.19KB +10%
demo/browser/polyfills.(hash).js
11.24KB +10%
demo/browser/styles.(hash).css
1.06KB +10%

Total files change +5B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.19MB (-19B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4beaa3) 70.88% compared to head (45e5fea) 69.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6608      +/-   ##
==========================================
- Coverage   70.88%   69.39%   -1.49%     
==========================================
  Files        1461     1143     -318     
  Lines       15938    12503    -3435     
  Branches     2291     1759     -532     
==========================================
- Hits        11298     8677    -2621     
+ Misses       4265     3542     -723     
+ Partials      375      284      -91     
Flag Coverage Δ
summary 69.39% <ø> (-1.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waterplea
Copy link
Collaborator

I need mixins in a pet project, and pretty sure I'm not the only one. We can probably drop mixins that are not meant for public use, like textfield or picker however. Let's wait until I refactor textfields.

@waterplea waterplea closed this Jan 30, 2024
@splincode splincode deleted the splincode/feat-drop-scss branch January 30, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants