Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert regression #6605

Merged
merged 1 commit into from
Jan 30, 2024
Merged

chore: revert regression #6605

merged 1 commit into from
Jan 30, 2024

Conversation

splincode
Copy link
Member

@splincode splincode commented Jan 30, 2024

Copy link

lumberjack-bot bot commented Jan 30, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 360e53e):

https://taiga-ui--pr6605-chore-revert-9ugy445a.web.app

(expires Wed, 31 Jan 2024 10:15:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Jan 30, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
345.98KB +10%
demo/browser/vendor.(hash).js
214.63KB +10%
demo/browser/runtime.(hash).js
34.18KB +10%
demo/browser/polyfills.(hash).js
11.24KB +10%
demo/browser/styles.(hash).css
1.06KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.19MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4beaa3) 70.88% compared to head (360e53e) 69.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6605      +/-   ##
==========================================
- Coverage   70.88%   69.39%   -1.49%     
==========================================
  Files        1461     1143     -318     
  Lines       15938    12503    -3435     
  Branches     2291     1759     -532     
==========================================
- Hits        11298     8677    -2621     
+ Misses       4265     3542     -723     
+ Partials      375      284      -91     
Flag Coverage Δ
summary 69.39% <ø> (-1.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"@nx/angular": "17.2.8",
"@nx/jest": "17.2.8",
"@nx/node": "17.2.8",
"@nx/workspace": "17.2.8",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you temporary disable auto update of nx for renovate bot ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@splincode splincode merged commit 6f14584 into main Jan 30, 2024
28 checks passed
@splincode splincode deleted the chore/revert branch January 30, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants