Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): endWith should be pass after takeUntil #6581

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

splincode
Copy link
Member

Copy link

lumberjack-bot bot commented Jan 27, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

Visit the preview URL for this PR (updated for commit b944374):

https://taiga-ui--pr6581-splincode-fix-scroll-96knllxr.web.app

(expires Sun, 28 Jan 2024 21:55:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Jan 27, 2024

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+381.66KB +10%
demo/browser/vendor.(hash).js
+212.98KB +10%
demo/browser/runtime.(hash).js
+39.94KB +10%
demo/browser/polyfills.(hash).js
+11.25KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +647.22KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.33MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v3.x@2f375e1). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             v3.x    #6581   +/-   ##
=======================================
  Coverage        ?   72.01%           
=======================================
  Files           ?     1457           
  Lines           ?    16014           
  Branches        ?     2289           
=======================================
  Hits            ?    11532           
  Misses          ?     4109           
  Partials        ?      373           
Flag Coverage Δ
addon-charts 71.46% <0.00%> (?)
addon-doc 60.40% <0.00%> (?)
addon-mobile 60.63% <0.00%> (?)
addon-table 60.75% <0.00%> (?)
addon-tablebars 96.15% <0.00%> (?)
cdk 78.48% <0.00%> (?)
core 77.93% <0.00%> (?)
kit 70.28% <0.00%> (?)
summary 72.01% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, didn't know it is relevant

@splincode splincode merged commit 14da1e0 into v3.x Jan 29, 2024
34 checks passed
@splincode splincode deleted the splincode/fix/scroll branch January 29, 2024 09:36
This was referenced Jan 31, 2024
This was referenced Feb 20, 2024
This was referenced Mar 19, 2024
This was referenced Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants