Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Note instead of TODO #6578

Closed
wants to merge 1 commit into from
Closed

Conversation

splincode
Copy link
Member

@splincode splincode commented Jan 27, 2024

Exclude from IDEA todo list

image

Copy link

lumberjack-bot bot commented Jan 27, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Jan 27, 2024

Visit the preview URL for this PR (updated for commit 572f055):

https://taiga-ui--pr6578-splincode-refactor-s-c0qzovc0.web.app

(expires Sun, 28 Jan 2024 20:23:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Jan 27, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
345.96KB +10%
demo/browser/vendor.(hash).js
214.62KB +10%
demo/browser/runtime.(hash).js
34.14KB +10%
demo/browser/polyfills.(hash).js
11.24KB +10%
demo/browser/styles.(hash).css
1.06KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.18MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode force-pushed the splincode/refactor-schematics branch from 0acf9c3 to e094abd Compare January 27, 2024 20:16
@splincode splincode force-pushed the splincode/refactor-schematics branch from e094abd to 572f055 Compare January 27, 2024 20:20
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be28334) 70.88% compared to head (572f055) 69.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6578      +/-   ##
==========================================
- Coverage   70.88%   69.39%   -1.49%     
==========================================
  Files        1461     1143     -318     
  Lines       15938    12503    -3435     
  Branches     2291     1759     -532     
==========================================
- Hits        11298     8677    -2621     
+ Misses       4265     3542     -723     
+ Partials      375      284      -91     
Flag Coverage Δ
summary 69.39% <ø> (-1.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode closed this Feb 1, 2024
@splincode splincode deleted the splincode/refactor-schematics branch February 1, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant