Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): when the consumer unsubscribes, clean up data ready for next subscription #6554

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

splincode
Copy link
Member

Closes #6553

Copy link

lumberjack-bot bot commented Jan 25, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Jan 25, 2024

Visit the preview URL for this PR (updated for commit 4fc4521):

https://taiga-ui--pr6554-splincode-fix-6553-dormiy41.web.app

(expires Sat, 27 Jan 2024 07:01:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Jan 25, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
388.55KB (+6.23KB +1.63%) +10%
demo/browser/runtime.(hash).js
34.09KB (-16B -0.05%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
214.62KB +10%
demo/browser/polyfills.(hash).js
11.24KB +10%
demo/browser/styles.(hash).css
1.06KB +10%

Total files change +6.21KB +0.97%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.18MB (-628B -0.03%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (75f9762) 69.59% compared to head (c6bcacc) 69.59%.
Report is 3 commits behind head on main.

❗ Current head c6bcacc differs from pull request most recent head 4fc4521. Consider uploading reports for the commit 4fc4521 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6554   +/-   ##
=======================================
  Coverage   69.59%   69.59%           
=======================================
  Files        1152     1152           
  Lines       12563    12564    +1     
  Branches     1763     1763           
=======================================
+ Hits         8743     8744    +1     
  Misses       3536     3536           
  Partials      284      284           
Flag Coverage Δ
summary 69.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode added the v4 4.0 candidate label Jan 25, 2024
projects/cdk/observables/control-value.ts Outdated Show resolved Hide resolved
@splincode splincode merged commit 0e2b2e3 into main Jan 26, 2024
13 checks passed
@splincode splincode deleted the splincode/fix/6553 branch January 26, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

🐞 - tuiControlValue memory leak
3 participants