-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(experimental): add card-large #6516
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
1f91127
to
a9767d6
Compare
BundleMonFiles added (5)
Total files change +649.16KB Groups added (1)
Final result: ✅ View report in BundleMon website ➡️ |
Visit the preview URL for this PR (updated for commit 9842223): https://taiga-ui--pr6516-splincode-feat-card-o8sidp53.web.app (expires Thu, 01 Feb 2024 15:25:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3.x #6516 +/- ##
======================================
Coverage ? 0
======================================
Files ? 0
Lines ? 0
Branches ? 0
======================================
Hits ? 0
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
e1f707b
to
935b7ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Examples 1, 3 and 4 need some style tweaks to look good on mobile
- Let's remove typescript tab from examples
- I think card list scroll should have negative horizontal margin to start and end at the edge of the card. Let's change this in the demo for now, and in future maybe we will add something to the kit to make it easier.
- Examples stretch to full width on desktop, let's limit them for better appearance
- Paddings are wrong:
and
projects/demo/src/modules/experimental/card/examples/18/index.less
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/experimental/card/examples/17/index.less
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/experimental/card/examples/16/index.less
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/experimental/card/examples/15/index.html
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/experimental/card/examples/14/index.ts
Outdated
Show resolved
Hide resolved
7934365
to
70a0a1a
Compare
f2ab062
to
9ae0767
Compare
projects/demo/src/modules/experimental/card/examples/13/index.less
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/experimental/card/examples/18/index.less
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/experimental/card/examples/8/index.less
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/experimental/card/examples/8/index.less
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/experimental/card/examples/11/index.less
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/experimental/card/examples/11/index.less
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/experimental/card/examples/11/index.less
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/experimental/card/examples/11/index.less
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/experimental/card/examples/10/index.less
Outdated
Show resolved
Hide resolved
af1f607
to
6493a4a
Compare
projects/demo/src/modules/experimental/card/examples/10/index.html
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/experimental/card/examples/10/index.html
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/experimental/card/examples/10/index.html
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/experimental/card/examples/10/index.html
Outdated
Show resolved
Hide resolved
6493a4a
to
841e212
Compare
841e212
to
f4b3eab
Compare
06adb7a
to
9842223
Compare
PR Type
What kind of change does this PR introduce?