Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): add card-large #6516

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

Copy link

lumberjack-bot bot commented Jan 22, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode splincode force-pushed the splincode/feat/card-large branch from 1f91127 to a9767d6 Compare January 22, 2024 19:56
Copy link

bundlemon bot commented Jan 22, 2024

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+383.04KB +10%
demo/browser/vendor.(hash).js
+212.98KB +10%
demo/browser/runtime.(hash).js
+40.5KB +10%
demo/browser/polyfills.(hash).js
+11.25KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +649.16KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.35MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

Copy link
Contributor

github-actions bot commented Jan 22, 2024

Visit the preview URL for this PR (updated for commit 9842223):

https://taiga-ui--pr6516-splincode-feat-card-o8sidp53.web.app

(expires Thu, 01 Feb 2024 15:25:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v3.x@63792e7). Click here to learn what that means.

❗ Current head f4b3eab differs from pull request most recent head 9842223. Consider uploading reports for the commit 9842223 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##             v3.x   #6516   +/-   ##
======================================
  Coverage        ?       0           
======================================
  Files           ?       0           
  Lines           ?       0           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?       0           
  Partials        ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode added the v3 label Jan 23, 2024
@splincode splincode force-pushed the splincode/feat/card-large branch 2 times, most recently from e1f707b to 935b7ce Compare January 24, 2024 15:04
@splincode splincode requested a review from waterplea January 24, 2024 15:04
Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Examples 1, 3 and 4 need some style tweaks to look good on mobile
  2. Let's remove typescript tab from examples
  3. I think card list scroll should have negative horizontal margin to start and end at the edge of the card. Let's change this in the demo for now, and in future maybe we will add something to the kit to make it easier.
  4. Examples stretch to full width on desktop, let's limit them for better appearance
  5. Paddings are wrong:

image

and

image

@splincode splincode force-pushed the splincode/feat/card-large branch 3 times, most recently from 7934365 to 70a0a1a Compare January 26, 2024 13:32
@splincode splincode requested a review from waterplea January 26, 2024 13:35
@splincode splincode force-pushed the splincode/feat/card-large branch 2 times, most recently from f2ab062 to 9ae0767 Compare January 29, 2024 10:11
@splincode splincode force-pushed the splincode/feat/card-large branch 2 times, most recently from af1f607 to 6493a4a Compare January 29, 2024 16:40
@splincode splincode force-pushed the splincode/feat/card-large branch from 6493a4a to 841e212 Compare January 30, 2024 08:01
@splincode splincode requested a review from waterplea January 30, 2024 08:16
@splincode splincode force-pushed the splincode/feat/card-large branch from 841e212 to f4b3eab Compare January 30, 2024 09:09
projects/demo/src/modules/app/pages.ts Outdated Show resolved Hide resolved
@splincode splincode force-pushed the splincode/feat/card-large branch from 06adb7a to 9842223 Compare January 31, 2024 15:22
@splincode splincode merged commit 699c8bc into v3.x Jan 31, 2024
14 of 20 checks passed
@splincode splincode deleted the splincode/feat/card-large branch January 31, 2024 15:24
This was referenced Jan 31, 2024
This was referenced Feb 20, 2024
This was referenced Mar 19, 2024
This was referenced Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants