Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo): explicit ng-dev-mode #6508

Closed
wants to merge 36 commits into from
Closed

chore(demo): explicit ng-dev-mode #6508

wants to merge 36 commits into from

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

splincode and others added 25 commits December 13, 2023 15:07
Co-authored-by: taiga-family-bot <[email protected]>
…hide blinking initial view (#6459)

Co-authored-by: taiga-family-bot <[email protected]>
Copy link

lumberjack-bot bot commented Jan 22, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Jan 22, 2024

Visit the preview URL for this PR (updated for commit f4b3cab):

https://taiga-ui--pr6508-splincode-fix-clgzy71p.web.app

(expires Wed, 24 Jan 2024 08:13:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Jan 22, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
386.73KB +10%
demo/browser/vendor.(hash).js
214.63KB +10%
demo/browser/runtime.(hash).js
33.96KB +10%
demo/browser/polyfills.(hash).js
11.24KB +10%
demo/browser/styles.(hash).css
1.06KB +10%

Total files change -4B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.3MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 93 lines in your changes are missing coverage. Please review.

Comparison is base (205be6a) 71.97% compared to head (f4b3cab) 69.51%.
Report is 219 commits behind head on main.

❗ Current head f4b3cab differs from pull request most recent head 68aeef5. Consider uploading reports for the commit 68aeef5 to get more accurate results

Files Patch % Lines
.../cdk/directives/auto-focus/handlers/ios.handler.ts 0.00% 16 Missing ⚠️
...ojects/addon-commerce/utils/get-currency-symbol.ts 59.45% 15 Missing ⚠️
projects/addon-doc/pipes/markdown/markdown.pipe.ts 41.17% 10 Missing ⚠️
...rojects/addon-mobile/components/sheet/ios.hacks.ts 11.11% 8 Missing ⚠️
...ommerce/utils/create-auto-corrected-expire-pipe.ts 0.00% 5 Missing ⚠️
projects/cdk/decorators/pure.ts 0.00% 0 Missing and 4 partials ⚠️
...n-doc/components/documentation/pipes/color.pipe.ts 0.00% 1 Missing and 2 partials ⚠️
...doc/components/documentation/pipes/opacity.pipe.ts 0.00% 2 Missing and 1 partial ⚠️
...doc/components/documentation/pipes/inspect.pipe.ts 0.00% 2 Missing ⚠️
projects/addon-doc/utils/provide-route-page-tab.ts 0.00% 1 Missing and 1 partial ⚠️
... and 22 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6508      +/-   ##
==========================================
- Coverage   71.97%   69.51%   -2.47%     
==========================================
  Files        1457     1156     -301     
  Lines       16025    12593    -3432     
  Branches     2286     1764     -522     
==========================================
- Hits        11534     8754    -2780     
+ Misses       4118     3555     -563     
+ Partials      373      284      -89     
Flag Coverage Δ
addon-charts ?
addon-doc ?
addon-mobile ?
addon-table ?
addon-tablebars ?
cdk ?
core ?
kit ?
summary 69.51% <70.84%> (-2.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode closed this Jan 23, 2024
@splincode splincode deleted the splincode/fix branch January 23, 2024 08:07
@splincode splincode restored the splincode/fix branch January 23, 2024 08:08
@splincode splincode reopened this Jan 23, 2024
@splincode splincode closed this Jan 25, 2024
@splincode splincode deleted the splincode/fix branch January 25, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants