Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): File add ability to customize icons #6417

Merged
merged 2 commits into from
Jan 10, 2024
Merged

feat(kit): File add ability to customize icons #6417

merged 2 commits into from
Jan 10, 2024

Conversation

vladimirpotekhin
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes #6405

What is the new behaviour?

Copy link

lumberjack-bot bot commented Jan 10, 2024

Failed tests ❌

After <= Diff => Before

tests-deep-deep-select-Deep-Select-components-input-card-grouped-chromium-retry1/deep--components-input-card-grouped-cardSrc--select-option-0.diff.png
tests-deep-deep-select-Deep-Select-components-input-card-grouped-chromium/deep--components-input-card-grouped-cardSrc--select-option-0.diff.png
tests-kit-dropdown-context-dropdown-context-Dr-62150-loses-previous-dropdown-after-new-one-is-opened-chromium-retry1/03-dropdown-context.diff.png
tests-kit-dropdown-context-dropdown-context-Dr-62150-loses-previous-dropdown-after-new-one-is-opened-chromium-retry2/03-dropdown-context.diff.png
tests-kit-dropdown-context-dropdown-context-Dr-62150-loses-previous-dropdown-after-new-one-is-opened-chromium/03-dropdown-context.diff.png

(updated for commit 395d6e2)

Copy link

bundlemon bot commented Jan 10, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
383.26KB (+32B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
214.63KB +10%
demo/browser/runtime.(hash).js
33.97KB +10%
demo/browser/polyfills.(hash).js
11.24KB +10%
demo/browser/styles.(hash).css
1.06KB +10%

Total files change +32B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.29MB (+32B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 395d6e2):

https://taiga-ui--pr6417-files-icons-aty0u9vr.web.app

(expires Thu, 11 Jan 2024 15:04:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f1fbee2) 70.93% compared to head (395d6e2) 69.46%.
Report is 3 commits behind head on main.

Files Patch % Lines
projects/kit/components/files/file/file-options.ts 50.00% 1 Missing ⚠️
...ojects/kit/components/files/file/file.component.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6417      +/-   ##
==========================================
- Coverage   70.93%   69.46%   -1.47%     
==========================================
  Files        1466     1156     -310     
  Lines       16014    12610    -3404     
  Branches     2305     1769     -536     
==========================================
- Hits        11359     8760    -2599     
+ Misses       4280     3566     -714     
+ Partials      375      284      -91     
Flag Coverage Δ
summary 69.46% <84.61%> (-1.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode merged commit 97746d9 into main Jan 10, 2024
24 of 25 checks passed
@splincode splincode deleted the files-icons branch January 10, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 4.0 candidate
Development

Successfully merging this pull request may close these issues.

🚀 - Use new icon from Tinkoff 2023 Theme in TuiInputFiles
3 participants