feat(addon-doc): display emission in @Output wherever possible
#6171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demensky
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin,
nsbarsukov and
splincode
as code owners
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
splincode
approved these changes
Dec 6, 2023
splincode
approved these changes
Dec 6, 2023
BundleMonFiles updated (1)
Unchanged files (4)
Total files change +19B 0% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6171 +/- ##
===========================================
- Coverage 71.92% 59.87% -12.05%
===========================================
Files 1464 89 -1375
Lines 16024 987 -15037
Branches 2283 106 -2177
===========================================
- Hits 11525 591 -10934
+ Misses 4127 377 -3750
+ Partials 372 19 -353
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
splincode
changed the title
@Output wherever possible@Output wherever possible
waterplea
reviewed
Dec 6, 2023
projects/addon-doc/components/documentation/documentation-property-connector.directive.ts
Outdated
Show resolved
Hide resolved
waterplea
approved these changes
Dec 6, 2023
splincode
reviewed
Dec 6, 2023
| content = tuiInspectAny(event, 2); | ||
| } | ||
|
|
||
| this.alerts.open(content, {label: this.attrName}).subscribe(); |
There was a problem hiding this comment.
Can we use instead of alerts notifications our custom console tab inside content example?
for example
There was a problem hiding this comment.
in this case, it would not irritate users too much
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behaviour?
@Outputis not shown (flashing) in the demo.What is the new behaviour?
@Outputis shown (flashed) in the demo. The alert is also displayed, except for(focusedChange).