Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo-playwright): tests for field-error #6133

Merged
merged 12 commits into from
Nov 30, 2023

Conversation

AtharvChandratre
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Addresses #4912

What is the new behaviour?

This PR adds an e2e test (with playwright) for field-error

Copy link

lumberjack-bot bot commented Nov 30, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1dcbee6) 71.90% compared to head (1add0f0) 71.93%.

❗ Current head 1add0f0 differs from pull request most recent head 8d80a8e. Consider uploading reports for the commit 8d80a8e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6133      +/-   ##
==========================================
+ Coverage   71.90%   71.93%   +0.03%     
==========================================
  Files        1462     1462              
  Lines       15995    15987       -8     
  Branches     2274     2273       -1     
==========================================
  Hits        11501    11501              
+ Misses       4122     4115       -7     
+ Partials      372      371       -1     
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 59.43% <ø> (ø)
addon-mobile 60.49% <ø> (ø)
addon-table 60.75% <ø> (+0.38%) ⬆️
addon-tablebars 90.90% <ø> (ø)
cdk 78.65% <ø> (ø)
core 78.00% <ø> (+0.11%) ⬆️
kit 70.19% <ø> (ø)
summary 71.93% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Nov 30, 2023

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
374.85KB +10%
demo/browser/vendor.(hash).js
198.18KB +10%
demo/browser/runtime.(hash).js
41.1KB +10%
demo/browser/polyfills.(hash).js
11.22KB +10%
demo/browser/styles.(hash).css
1.22KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.28MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode merged commit 7944f20 into taiga-family:main Nov 30, 2023
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants