-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(experimental): Chip
add new component
#6076
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonFiles updated (3)
Unchanged files (2)
Total files change -28.24KB -4.53% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Visit the preview URL for this PR (updated for commit 51b1462): https://taiga-ui--pr6076-chip-fmxei108.web.app (expires Sat, 25 Nov 2023 07:59:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6076 +/- ##
==========================================
- Coverage 71.94% 70.44% -1.50%
==========================================
Files 1462 1101 -361
Lines 15970 13053 -2917
Branches 2266 1833 -433
==========================================
- Hits 11489 9195 -2294
+ Misses 4110 3549 -561
+ Partials 371 309 -62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
<img | ||
*ngIf="size === 'm' || size === 's'" | ||
alt="Avatar" | ||
src="/assets/images/avatar.jpg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appearance="secondary" | ||
iconLeft="tuiIconBell" | ||
> | ||
Notifications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Less gap between Bell
-icon and word "Notifications" 🤔
gap: 1rem; | ||
} | ||
|
||
section { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this example more mobile-friendly:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flex-wrap: wrap
?
FormsModule, | ||
TuiChipModule, | ||
TuiRepeatTimesModule, | ||
TuiIconModule, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Type
What kind of change does this PR introduce?
What is the current behaviour?
Closes #
What is the new behaviour?