Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): Chip add new component #6076

Merged
merged 4 commits into from
Nov 24, 2023
Merged

feat(experimental): Chip add new component #6076

merged 4 commits into from
Nov 24, 2023

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes #

What is the new behaviour?

Copy link

lumberjack-bot bot commented Nov 23, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

bundlemon bot commented Nov 23, 2023

BundleMon

Files updated (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
198.19KB (+55B +0.03%) +10%
demo/browser/runtime.(hash).js
40.74KB (-16B -0.04%) +10%
demo/browser/main.(hash).js
344.26KB (-28.28KB -7.59%) +10%
Unchanged files (2)
Status Path Size Limits
demo/browser/polyfills.(hash).js
11.22KB +10%
demo/browser/styles.(hash).css
1.22KB +10%

Total files change -28.24KB -4.53%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.27MB (+998B +0.04%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Nov 23, 2023

Visit the preview URL for this PR (updated for commit 51b1462):

https://taiga-ui--pr6076-chip-fmxei108.web.app

(expires Sat, 25 Nov 2023 07:59:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6883895) 71.94% compared to head (51b1462) 70.44%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6076      +/-   ##
==========================================
- Coverage   71.94%   70.44%   -1.50%     
==========================================
  Files        1462     1101     -361     
  Lines       15970    13053    -2917     
  Branches     2266     1833     -433     
==========================================
- Hits        11489     9195    -2294     
+ Misses       4110     3549     -561     
+ Partials      371      309      -62     
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 59.62% <ø> (ø)
addon-mobile 60.61% <ø> (ø)
addon-table 60.75% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk ∅ <ø> (∅)
core 77.99% <ø> (ø)
kit 70.18% <ø> (ø)
summary 70.44% <ø> (-1.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

<img
*ngIf="size === 'm' || size === 's'"
alt="Avatar"
src="/assets/images/avatar.jpg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mac OS Chrome:
chrome


Mac OS Safari (Version 16.5.2 (18615.2.9.11.10))
safari

appearance="secondary"
iconLeft="tuiIconBell"
>
Notifications
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chrome:
chrome


Safari:
safari

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less gap between Bell-icon and word "Notifications" 🤔

gap: 1rem;
}

section {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this example more mobile-friendly:

iphone12

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flex-wrap: wrap ?

FormsModule,
TuiChipModule,
TuiRepeatTimesModule,
TuiIconModule,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon

@waterplea waterplea merged commit 49cd976 into main Nov 24, 2023
35 of 36 checks passed
@waterplea waterplea deleted the chip branch November 24, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants