Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo): improve LCP #5854

Merged
merged 1 commit into from
Nov 7, 2023
Merged

chore(demo): improve LCP #5854

merged 1 commit into from
Nov 7, 2023

Conversation

splincode
Copy link
Member

@splincode splincode commented Nov 5, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

Before:

image image

After:

image image

Copy link

bundlemon bot commented Nov 5, 2023

BundleMon

Files updated (3)
Status Path Size Limits
demo/browser/runtime.(hash).js
39.46KB (-15B -0.04%) +10%
demo/browser/vendor.(hash).js
200.77KB (-148B -0.07%) +10%
demo/browser/main.(hash).js
339.99KB (-1.05KB -0.31%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change -1.21KB -0.2%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.24MB (-1.21KB -0.05%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

lumberjack-bot bot commented Nov 5, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode splincode changed the title chore(demo): refactor landing page for improve LCP chore(demo): improve LCP Nov 5, 2023
Copy link
Contributor

github-actions bot commented Nov 5, 2023

Visit the preview URL for this PR (updated for commit 61a2af9):

https://taiga-ui--pr5854-splincode-ci-demo-rgczu1mt.web.app

(expires Wed, 08 Nov 2023 08:38:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #5854 (61a2af9) into main (5a1e81f) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5854   +/-   ##
=======================================
  Coverage   71.92%   71.92%           
=======================================
  Files        1462     1462           
  Lines       15962    15962           
  Branches     2261     2261           
=======================================
  Hits        11481    11481           
  Misses       4111     4111           
  Partials      370      370           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 59.66% <ø> (ø)
addon-mobile 60.80% <ø> (ø)
addon-table 60.63% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.65% <ø> (ø)
core 77.96% <ø> (ø)
kit 70.10% <ø> (ø)
summary 71.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@splincode splincode force-pushed the splincode/ci/demo branch 2 times, most recently from ab67541 to ec25ee2 Compare November 7, 2023 07:45
@splincode splincode merged commit 6de319f into main Nov 7, 2023
34 checks passed
@splincode splincode deleted the splincode/ci/demo branch November 7, 2023 11:12
AtharvChandratre pushed a commit to AtharvChandratre/taiga-ui that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants