fix(cdk): compat static requests with SSR #5653
Conversation
splincode
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin and
nsbarsukov
as code owners
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonFiles updated (1)
Unchanged files (5)
Total files change +129B +0.02% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
|
Visit the preview URL for this PR (updated for commit 97b1d81): https://taiga-ui--pr5653-splincode-fix-issues-1ww68sk7.web.app (expires Tue, 17 Oct 2023 15:42:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
splincode
force-pushed
the
splincode/fix/issues/4063
branch
from
f734b4e to
97b1d81
Compare
Codecov Report
@@ Coverage Diff @@
## main #5653 +/- ##
==========================================
+ Coverage 72.31% 72.35% +0.03%
==========================================
Files 1442 1448 +6
Lines 15721 15784 +63
Branches 2215 2222 +7
==========================================
+ Hits 11369 11420 +51
- Misses 3990 4001 +11
- Partials 362 363 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| ? `${hostname}${port}/${this.baseHref}` | ||
| : this.baseHref; | ||
|
|
||
| url = `${baseUrl}/${url}`.replace(/(https?:\/\/)|(\/)+/g, `$1$2`); |
There was a problem hiding this comment.
I confirm that there are no more warning in console.
But icons still do not work during SSR 🤔
There was a problem hiding this comment.
@splincode
Should we merge this PR and create the separate issue for absence of icons ?
Or it can be solved in this PR?
| @@ -23,6 +26,17 @@ export class TuiStaticRequestService { | |||
| return cache; | |||
| } | |||
|
|
|||
| if (!url.startsWith(`http`)) { | |||
There was a problem hiding this comment.
Why do we need all this? If it was working under CSR, should we only do this under SSR?
PR Type
What kind of change does this PR introduce?
What is the current behaviour?
Closes #4063