-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(addon-table): table disappearing borders #5650
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonUnchanged files (6)
Total files change +1B 0% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov Report
@@ Coverage Diff @@
## main #5650 +/- ##
==========================================
+ Coverage 72.36% 73.56% +1.19%
==========================================
Files 1451 744 -707
Lines 15803 9105 -6698
Branches 2224 1393 -831
==========================================
- Hits 11436 6698 -4738
+ Misses 4006 2163 -1843
+ Partials 361 244 -117
Flags with carried forward coverage won't be shown. Click here to find out more. see 715 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -31,6 +35,12 @@ | |||
} | |||
} | |||
|
|||
@keyframes repaint { | |||
to { | |||
border-right-color: var(--tui-base-04); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
People might want to override this. Can we do something like isolation: isolate
here? Or some other harmless rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this, but it's doesn't work. I'm gonna try to find another solution, but if i won't find it, we can just add a css variable for table border-color, and use it in animation. What do you think?
PR Type
What kind of change does this PR introduce?
What is the current behaviour?
Closes #5645
What is the new behaviour?
I added a simple animation for "th" and "td" which updates the border-color. The same animation but with setting "isolation: isolate" doesn't work as needed
It's fixes a bug, but there's a problem: if we want to customize the border-color, we also should change the animation