Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-table): table disappearing borders #5650

Closed
wants to merge 2 commits into from
Closed

fix(addon-table): table disappearing borders #5650

wants to merge 2 commits into from

Conversation

Smedrix
Copy link
Contributor

@Smedrix Smedrix commented Oct 16, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes #5645

What is the new behaviour?

I added a simple animation for "th" and "td" which updates the border-color. The same animation but with setting "isolation: isolate" doesn't work as needed

It's fixes a bug, but there's a problem: if we want to customize the border-color, we also should change the animation

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 16, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Oct 16, 2023

BundleMon

Unchanged files (6)
Status Path Size Limits
demo/browser/main.(hash).js
338.48KB +10%
demo/browser/vendor.(hash).js
201.45KB +10%
demo/browser/runtime.(hash).js
38.12KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +1B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.21MB (+62B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #5650 (16e7937) into main (eacd5b3) will increase coverage by 1.19%.
The diff coverage is n/a.

❗ Current head 16e7937 differs from pull request most recent head 61cf967. Consider uploading reports for the commit 61cf967 to get more accurate results

@@            Coverage Diff             @@
##             main    #5650      +/-   ##
==========================================
+ Coverage   72.36%   73.56%   +1.19%     
==========================================
  Files        1451      744     -707     
  Lines       15803     9105    -6698     
  Branches     2224     1393     -831     
==========================================
- Hits        11436     6698    -4738     
+ Misses       4006     2163    -1843     
+ Partials      361      244     -117     
Flag Coverage Δ
addon-charts ?
addon-doc ?
addon-mobile ?
addon-table ?
addon-tablebars ?
cdk ?
core 78.16% <ø> (+0.05%) ⬆️
kit 70.91% <ø> (+0.02%) ⬆️
summary 73.56% <ø> (+1.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 715 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -31,6 +35,12 @@
}
}

@keyframes repaint {
to {
border-right-color: var(--tui-base-04);
Copy link
Collaborator

@waterplea waterplea Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People might want to override this. Can we do something like isolation: isolate here? Or some other harmless rule.

Copy link
Contributor Author

@Smedrix Smedrix Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this, but it's doesn't work. I'm gonna try to find another solution, but if i won't find it, we can just add a css variable for table border-color, and use it in animation. What do you think?

@Smedrix Smedrix closed this Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - Table disappearing borders
2 participants