fix: migrate styles-components from using selectors #5635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakhramoff
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin,
nsbarsukov and
splincode
as code owners
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
vakhramoff
force-pushed
the
bugfix/ng0912-warning
branch
from
b875588 to
8943f49
Compare
vakhramoff
changed the title
BundleMonFiles updated (1)
Unchanged files (5)
Total files change +52B +0.01% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
|
Visit the preview URL for this PR (updated for commit ee704c6): https://taiga-ui--pr5635-bugfix-ng0912-warnin-2e5bubv8.web.app (expires Sat, 14 Oct 2023 16:38:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
Codecov Report
@@ Coverage Diff @@
## main #5635 +/- ##
=======================================
Coverage 72.39% 72.39%
=======================================
Files 1448 1448
Lines 15773 15773
Branches 2216 2216
=======================================
Hits 11419 11419
Misses 3992 3992
Partials 362 362
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vakhramoff
force-pushed
the
bugfix/ng0912-warning
branch
from
8943f49 to
ee704c6
Compare
splincode
approved these changes
Oct 13, 2023
waterplea
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behaviour?
Developers that are using Angular 16 currently are facing an issue having an NG0912 compilation warning.
Closes #5606
What is the new behaviour?
Styles components now use host.class to insure that there will be no similar metadata for two different components. The additional side-effect, a bonus, of this approach is that the IDE won't suggest these components to use in the template.