Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo-playwright): implement icons customization tests #5607

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

aotulana
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Addresses #4912

What is the new behavior?

This PR adds playwright e2e test for icons customization

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 12, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Oct 12, 2023

BundleMon

Unchanged files (6)
Status Path Size Limits
demo/browser/main.(hash).js
335.99KB +10%
demo/browser/vendor.(hash).js
201.19KB +10%
demo/browser/runtime.(hash).js
38.03KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.17MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #5607 (774c372) into main (a85ee21) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5607   +/-   ##
=======================================
  Coverage   72.37%   72.37%           
=======================================
  Files        1447     1447           
  Lines       15767    15767           
  Branches     2215     2215           
=======================================
  Hits        11412    11412           
  Misses       3993     3993           
  Partials      362      362           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 60.53% <ø> (ø)
addon-mobile 61.14% <ø> (ø)
addon-table 61.01% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.74% <ø> (ø)
core 78.09% <ø> (ø)
kit 70.91% <ø> (ø)
summary 72.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@splincode splincode force-pushed the icons-customization-e2e branch from 6056b3c to b87be5d Compare October 12, 2023 05:39
@aotulana aotulana force-pushed the icons-customization-e2e branch from b87be5d to 774c372 Compare October 12, 2023 14:01
@aotulana aotulana requested a review from nsbarsukov October 12, 2023 14:03
@nsbarsukov nsbarsukov merged commit 0e61adf into taiga-family:main Oct 12, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants