-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(demo-playwright): implement icons customization tests #5607
Merged
nsbarsukov
merged 2 commits into
taiga-family:main
from
aotulana:icons-customization-e2e
Oct 12, 2023
Merged
chore(demo-playwright): implement icons customization tests #5607
nsbarsukov
merged 2 commits into
taiga-family:main
from
aotulana:icons-customization-e2e
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aotulana
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin,
nsbarsukov and
splincode
as code owners
October 12, 2023 05:21
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
splincode
approved these changes
Oct 12, 2023
BundleMonUnchanged files (6)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov Report
@@ Coverage Diff @@
## main #5607 +/- ##
=======================================
Coverage 72.37% 72.37%
=======================================
Files 1447 1447
Lines 15767 15767
Branches 2215 2215
=======================================
Hits 11412 11412
Misses 3993 3993
Partials 362 362
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
splincode
force-pushed
the
icons-customization-e2e
branch
from
October 12, 2023 05:39
6056b3c
to
b87be5d
Compare
nsbarsukov
reviewed
Oct 12, 2023
aotulana
force-pushed
the
icons-customization-e2e
branch
from
October 12, 2023 14:01
b87be5d
to
774c372
Compare
nsbarsukov
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Addresses #4912
What is the new behavior?
This PR adds playwright e2e test for icons customization