Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): ValueChanges add distinctUntilChanged #5586

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 10, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Oct 10, 2023

BundleMon

Unchanged files (6)
Status Path Size Limits
demo/browser/main.(hash).js
335.83KB +10%
demo/browser/vendor.(hash).js
200.86KB +10%
demo/browser/runtime.(hash).js
37.74KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change -2B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.16MB (-580B -0.03%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 256e008):

https://taiga-ui--pr5586-value-changes-h08qaivj.web.app

(expires Wed, 11 Oct 2023 07:40:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #5586 (256e008) into main (9f2e938) will not change coverage.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5586   +/-   ##
=======================================
  Coverage   72.39%   72.39%           
=======================================
  Files        1447     1447           
  Lines       15764    15764           
  Branches     2211     2211           
=======================================
  Hits        11413    11413           
  Misses       3990     3990           
  Partials      361      361           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 60.53% <ø> (ø)
addon-mobile 61.14% <ø> (ø)
addon-table 61.01% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.74% <100.00%> (ø)
core 78.19% <ø> (ø)
kit 70.91% <ø> (ø)
summary 72.39% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...irectives/value-changes/value-changes.directive.ts 90.90% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@splincode splincode merged commit d3e40ad into main Oct 10, 2023
40 of 41 checks passed
@splincode splincode deleted the value-changes branch October 10, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants