Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support show native scrollbar #5580

Closed
wants to merge 1 commit into from

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the new behavior?

    providers: [
        tuiScrollbarOptionsProvider({
            native: true,
        }),
    ],

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 9, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Oct 9, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
335.96KB (+162B +0.05%) +10%
demo/browser/runtime.(hash).js
37.74KB (-34B -0.09%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.86KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +128B +0.02%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.16MB (+128B +0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Visit the preview URL for this PR (updated for commit e1eaedb):

https://taiga-ui--pr5580-splincode-feat-scrol-zh1r8yve.web.app

(expires Tue, 10 Oct 2023 14:32:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #5580 (e1eaedb) into main (d47129e) will increase coverage by 0.01%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main    #5580      +/-   ##
==========================================
+ Coverage   72.39%   72.41%   +0.01%     
==========================================
  Files        1447     1448       +1     
  Lines       15764    15774      +10     
  Branches     2211     2211              
==========================================
+ Hits        11413    11422       +9     
- Misses       3990     3991       +1     
  Partials      361      361              
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 60.53% <ø> (ø)
addon-mobile 61.14% <ø> (ø)
addon-table 61.01% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.74% <ø> (ø)
core 78.22% <91.66%> (+0.03%) ⬆️
kit 70.91% <ø> (ø)
summary 72.41% <91.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
projects/core/components/scrollbar/index.ts 100.00% <100.00%> (ø)
...s/core/components/scrollbar/scrollbar.component.ts 59.37% <100.00%> (+5.80%) ⬆️
...cts/core/components/scrollbar/scrollbar.options.ts 80.00% <80.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@waterplea
Copy link
Collaborator

What would be the purpose, though? 🤔 We need to be able to toggle native scrollbars on root, I guess, but for the rest you can just not use tui-scrollbar if you want native scrollbars. Am I missing some use case?

@splincode splincode closed this Oct 9, 2023
@splincode splincode deleted the splincode/feat/scrollbar branch October 9, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants